Differential D21161

Refine more Differential review state behaviors
ClosedPublic
Actions

Authored by epriestley on Apr 23 2020, 5:10 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Mar 31, 11:31 AM

	Unknown Object (File)
	Mon, Mar 25, 2:18 AM

	Unknown Object (File)
	Mar 10 2024, 2:17 PM

	Unknown Object (File)
	Feb 20 2024, 8:17 PM

	Unknown Object (File)
	Feb 19 2024, 5:51 PM

	Unknown Object (File)
	Feb 12 2024, 2:19 PM

	Unknown Object (File)
	Jan 28 2024, 2:21 PM

	Unknown Object (File)
	Dec 23 2023, 10:26 PM

View All 77 Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13516: Remove the "filetree" setting (so it's always enabled for everyone)
Commits: rPd2572f8b335a: Refine more Differential review state behaviors

Summary

Add an "Add Comment" navigation anchor.
Make selection state more clear.
Make hidden state tidier and more clear.
Hide "View Options" in the hidden state to dodge all the weird behaviors it implies.
Click to select/deselect changesets.
When you open the view dropdown menu, then press "h", close the dropdown menu.

Test Plan

Fiddled with all these behaviors.

Diff Detail

Repository

Branch

tree2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24200
Build 33332: Run Core Tests
Build 33331: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 23 2020, 5:10 PM

Harbormaster completed remote builds in B24200: Diff 50382.Apr 23 2020, 5:11 PM

epriestley requested review of this revision.Apr 23 2020, 5:11 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 23 2020, 5:14 PM

Closed by commit rPd2572f8b335a: Refine more Differential review state behaviors (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPd2572f8b335a: Refine more Differential review state behaviors.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

src/

applications/

differential/

engine/

DifferentialFileTreeEngine.php

13 lines

view/

DifferentialChangesetDetailView.php

4 lines

DifferentialChangesetListView.php

17 lines

transactions/

view/

PhabricatorApplicationTransactionCommentView.php

4 lines

webroot/

rsrc/

css/

application/

differential/

changeset-view.css

34 lines

phui/

phui-formation-view.css

10 lines

js/

application/

diff/

DiffChangeset.js

106 lines

DiffChangesetList.js

56 lines

Diff 50382

resources/celerity/map.php

Loading...

src/applications/differential/engine/DifferentialFileTreeEngine.php

Loading...

src/applications/differential/view/DifferentialChangesetDetailView.php

Loading...

src/applications/differential/view/DifferentialChangesetListView.php

Loading...

src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php

Loading...

webroot/rsrc/css/application/differential/changeset-view.css

Loading...

webroot/rsrc/css/phui/phui-formation-view.css

Loading...

webroot/rsrc/js/application/diff/DiffChangeset.js

Loading...

webroot/rsrc/js/application/diff/DiffChangesetList.js

Loading...