Page MenuHomePhabricator

Add a "FormationView" to support dynamic flank panels
ClosedPublic

Authored by epriestley on Apr 21 2020, 2:23 PM.
Tags
None
Referenced Files
F14086996: D21150.id50359.diff
Sat, Nov 23, 6:31 PM
Unknown Object (File)
Oct 21 2024, 7:32 PM
Unknown Object (File)
Oct 17 2024, 7:24 PM
Unknown Object (File)
Oct 12 2024, 5:51 AM
Unknown Object (File)
Sep 24 2024, 9:46 AM
Unknown Object (File)
Sep 3 2024, 12:41 PM
Unknown Object (File)
Sep 3 2024, 10:41 AM
Unknown Object (File)
Sep 3 2024, 4:42 AM
Subscribers
None

Details

Summary

Ref T13516. Currently, the "File Tree" element is a semi-dynamic side panel that's implemented as a special mode of a side nav panel.

This implementation is fairly clunky, and arose from organic growth out of the side nav. As such, it has some weird behaviors, doesn't have builtin support for show/hide, and can't generalize easily.

Introduce a "FormationView" which supports loading a page up with piles of side panels in various modes.

Test Plan

No callers and no user-visible impact.

Diff Detail

Repository
rP Phabricator
Branch
flank1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24177
Build 33298: Run Core Tests
Build 33297: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Apr 22 2020, 3:23 PM
This revision was automatically updated to reflect the committed changes.