Page MenuHomePhabricator

Restore editor behavior to Diffusion and support "\" shortcut
ClosedPublic

Authored by epriestley on Apr 19 2020, 3:57 PM.
Tags
None
Referenced Files
F18808044: D21149.id.diff
Sun, Oct 19, 4:45 AM
F18804182: D21149.id50347.diff
Sat, Oct 18, 6:40 AM
F18803797: D21149.id50347.diff
Sat, Oct 18, 4:03 AM
F18780389: D21149.id50358.diff
Sun, Oct 12, 10:31 AM
F18734252: D21149.id.diff
Tue, Sep 30, 10:50 PM
F18647193: D21149.diff
Sep 19 2025, 12:33 PM
F18466653: D21149.diff
Sep 2 2025, 10:33 AM
F18101022: D21149.diff
Aug 9 2025, 12:16 PM
Subscribers
None

Details

Summary

Ref T13515. This restores the "Open in Editor" behavior to Diffusion, and makes "\" work there.

The URI pattern is now sent as a structured template to the client, so the code will work properly if a file path contains "%l".

Test Plan
  • Clicked "Open in Editor" and pressed "\" in Diffusion when viewing a file.
  • Clicked a line, hit "\", got the file opened to that line.

Diff Detail

Repository
rP Phabricator
Branch
sticky12
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24165
Build 33285: Run Core Tests
Build 33284: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Apr 19 2020, 4:41 PM
This revision was automatically updated to reflect the committed changes.