Page MenuHomePhabricator

Restore editor behavior to Diffusion and support "\" shortcut
ClosedPublic

Authored by epriestley on Apr 19 2020, 3:57 PM.
Tags
None
Referenced Files
F15398991: D21149.diff
Mon, Mar 17, 2:17 AM
F15396445: D21149.id.diff
Sun, Mar 16, 2:21 PM
F15315828: D21149.id50358.diff
Thu, Mar 6, 6:12 PM
F15315823: D21149.id50347.diff
Thu, Mar 6, 6:11 PM
F15315811: D21149.diff
Thu, Mar 6, 6:11 PM
Unknown Object (File)
Feb 9 2025, 9:02 AM
Unknown Object (File)
Feb 9 2025, 9:02 AM
Unknown Object (File)
Feb 9 2025, 9:02 AM
Subscribers
None

Details

Summary

Ref T13515. This restores the "Open in Editor" behavior to Diffusion, and makes "\" work there.

The URI pattern is now sent as a structured template to the client, so the code will work properly if a file path contains "%l".

Test Plan
  • Clicked "Open in Editor" and pressed "\" in Diffusion when viewing a file.
  • Clicked a line, hit "\", got the file opened to that line.

Diff Detail

Repository
rP Phabricator
Branch
sticky12
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24165
Build 33285: Run Core Tests
Build 33284: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Apr 19 2020, 4:41 PM
This revision was automatically updated to reflect the committed changes.