Page MenuHomePhabricator

Remove the "Edit Multiple Files" external editor setting
ClosedPublic

Authored by epriestley on Apr 18 2020, 6:34 PM.
Tags
None
Referenced Files
F13106874: D21142.diff
Sat, Apr 27, 9:13 PM
Unknown Object (File)
Sun, Apr 7, 3:32 PM
Unknown Object (File)
Sun, Apr 7, 6:37 AM
Unknown Object (File)
Wed, Apr 3, 3:55 AM
Unknown Object (File)
Wed, Apr 3, 3:55 AM
Unknown Object (File)
Wed, Apr 3, 3:55 AM
Unknown Object (File)
Wed, Apr 3, 3:55 AM
Unknown Object (File)
Sat, Mar 30, 2:59 PM
Subscribers
None

Details

Summary

Ref T13515. No callsites actually use this, most editors don't support it, it doesn't seem terribly useful for the ones that do, it makes template-based APIs for line-number substitution complicated, and we can probably just loop on window.open() anyway.

Test Plan

Grepped for affected symbols, found no more references. Loaded settings page, saw no more setting.

Diff Detail

Repository
rP Phabricator
Branch
sticky6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24157
Build 33269: Run Core Tests
Build 33268: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Apr 19 2020, 4:02 PM
This revision was automatically updated to reflect the committed changes.