Differential D21136

When inlines would disable a file shield in a diff, still apply the shield if all the comments are collapsed
ClosedPublic
Actions

Authored by epriestley on Apr 17 2020, 5:32 PM.

Tags

None

Referenced Files

	F19232800: D21136.id50333.diff
	Sun, Dec 21, 5:29 PM

	F19083274: D21136.id50333.diff
	Tue, Dec 2, 12:33 PM

	F18985433: D21136.id50332.diff
	Nov 17 2025, 1:02 PM

	F18978592: D21136.diff
	Nov 16 2025, 7:59 PM

	F18868163: D21136.id.diff
	Nov 4 2025, 4:57 AM

	F18866532: D21136.diff
	Nov 3 2025, 5:42 PM

	F18797110: D21136.id50333.diff
	Oct 17 2025, 4:38 AM

	F18796737: D21136.diff
	Oct 17 2025, 4:05 AM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13515: Differential: Inlines and View Options
Commits: rP3adf082002aa: When inlines would disable a file shield in a diff, still apply the shield if…

Summary

Ref T13515. We "shield" some changesets, including generated code and intradiffs with no intermediate changes.

These files don't get shielded if they have inline comments.

But, if the viewer has collapsed all the comments, we can shield the file again.

Test Plan

Created a change affecting files A and B, with three diffs:
- Touch A and B.
- Touch B only.
- Touch nothing.
Added an inline to A and collapsed it.
Viewed Diff 1 vs Diff 2:
- Saw A collapse with a note about inlines.
- Saw B changes, normally.
Viewed Diff 2 vs Diff 3:
- Saw A collapse with a note about inlines.
- Saw B collapse normally.
Uncollapsed the inline, viewed 1v2 and 2v3, saw A expand in both cases.

Diff Detail

Repository

Branch

unchanged1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24150
Build 33256: Run Core Tests
Build 33255: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 17 2020, 5:32 PM

Harbormaster completed remote builds in B24150: Diff 50332.Apr 17 2020, 5:33 PM

epriestley requested review of this revision.Apr 17 2020, 5:33 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 17 2020, 5:52 PM

Closed by commit rP3adf082002aa: When inlines would disable a file shield in a diff, still apply the shield if… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP3adf082002aa: When inlines would disable a file shield in a diff, still apply the shield if….

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

parser/

DifferentialChangesetParser.php

77 lines

Diff 50332

src/applications/differential/parser/DifferentialChangesetParser.php

Loading...