Page MenuHomePhabricator
Differential D21135

Add an "Open in External Editor" keystroke to Differential
ClosedPublic
Actions

Authored by epriestley on Apr 17 2020, 4:52 PM.
Tags
None
Referenced Files
F19313904: D21135.id50331.diff
Thu, Dec 25, 1:55 AM
F19303504: D21135.id50331.diff
Wed, Dec 24, 1:43 AM
F19303116: D21135.id50330.diff
Tue, Dec 23, 6:16 PM
F19303044: D21135.id.diff
Tue, Dec 23, 4:56 PM
F19260930: D21135.diff
Mon, Dec 22, 4:43 PM
F19148641: D21135.diff
Wed, Dec 10, 6:18 PM
F19147847: D21135.diff
Wed, Dec 10, 4:49 PM
F19083273: D21135.id50331.diff
Dec 2 2025, 12:33 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13515: Differential: Inlines and View Options
Commits
rP3d966d8a41f1: Add an "Open in External Editor" keystroke to Differential
Summary

Ref T13515. See PHI1661. If a file is selected, add a keystroke to click the "Open in External Editor" link.

Test Plan

In Safari, Chrome, and Firefox: used "J" to select a file, then "\" to open it in an external editor. (In Safari and Chrome, this prompts.)

Diff Detail

Repository
rP Phabricator
Branch
editor1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24148
Build 33253: Run Core Tests
Build 33252: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 17 2020, 4:52 PM
Harbormaster completed remote builds in B24148: Diff 50330.Apr 17 2020, 4:53 PM
epriestley requested review of this revision.Apr 17 2020, 4:53 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 17 2020, 5:06 PM
Closed by commit rP3d966d8a41f1: Add an "Open in External Editor" keystroke to Differential (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP3d966d8a41f1: Add an "Open in External Editor" keystroke to Differential.

Revision Contents
Changeset List

PathSize
resources/
celerity/
src/
applications/
differential/
view/
59 lines
41 lines
webroot/
rsrc/
js/
application/
diff/
14 lines
38 lines

Diff 50330

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/differential/view/DifferentialChangesetDetailView.php

Loading...
View Options

src/applications/differential/view/DifferentialChangesetListView.php

Loading...
View Options

webroot/rsrc/js/application/diff/DiffChangeset.js

Loading...
View Options

webroot/rsrc/js/application/diff/DiffChangesetList.js

Loading...
Phabricator · Built by Phacility