Page MenuHomePhabricator

If the Conduit server asserts it has the "gzip" capability, compress requests
ClosedPublic

Authored by epriestley on Apr 14 2020, 11:45 PM.
Tags
None
Referenced Files
F13087796: D21119.diff
Thu, Apr 25, 1:06 AM
Unknown Object (File)
Sun, Apr 21, 5:19 PM
Unknown Object (File)
Sat, Apr 20, 5:12 PM
Unknown Object (File)
Mon, Apr 1, 6:16 AM
Unknown Object (File)
Mar 14 2024, 6:10 PM
Unknown Object (File)
Mar 14 2024, 6:10 PM
Unknown Object (File)
Mar 14 2024, 6:10 PM
Unknown Object (File)
Mar 14 2024, 6:10 PM
Subscribers
None

Details

Summary

Ref T13507. For various messy reasons we can't blindly assume the server supports "gzip" -- but if the server tells us it does, we're on firmer ground.

If the server returns an "X-Conduit-Capabilities: gzip" header and we have compression support locally, compress subsequent requests.

This restores D21073, which was reverted by D21076.

Test Plan

With a gzip-asserting server, added debugging code and ran various "arc" commands. Saw the 2nd..Nth calls hit compression code.

Diff Detail

Repository
rARC Arcanist
Branch
gzip2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24114
Build 33202: Run Core Tests
Build 33201: arc lint + arc unit