Tighten query compiler rules around spaces inside and after operators
ClosedPublic
Actions

Authored by epriestley on Apr 14 2020, 5:18 PM.

Details

Reviewers: None
Maniphest Tasks: T13509: Support "field present" and "field absent" operators in Ferret
Commits: rP143f86d60b5a: Tighten query compiler rules around spaces inside and after operators

Summary

Ref T13509. Since title:- cat is now ambiguous, forbid spaces after operators.

Also, forbid spaces inside operators, although this has no effect today.

Test Plan

Added unit tests, ran unit tests.

Diff Detail

Repository

rP Phabricator

Branch

ferret4

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24091
Build 33169: Run Core Tests
Build 33168: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 14 2020, 5:18 PM

Harbormaster completed remote builds in B24091: Diff 50273.Apr 14 2020, 5:19 PM

epriestley requested review of this revision.Apr 14 2020, 5:19 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 14 2020, 5:52 PM

Closed by commit rP143f86d60b5a: Tighten query compiler rules around spaces inside and after operators (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP143f86d60b5a: Tighten query compiler rules around spaces inside and after operators.

Revision Contents
Changeset List

Path

Size

src/

applications/

search/

compiler/

PhutilSearchQueryCompiler.php

55 lines

__tests__/

PhutilSearchQueryCompilerTestCase.php

28 lines

Diff 50273

View Options

src/applications/search/compiler/PhutilSearchQueryCompiler.php

View Options

src/applications/search/compiler/tests/PhutilSearchQueryCompilerTestCase.php

Tighten query compiler rules around spaces inside and after operatorsClosedPublicActions