Page MenuHomePhabricator
Differential D21085

Port "arc prompts" from wilds and fix a path issue in shell completion
ClosedPublic
Actions

Authored by epriestley on Apr 11 2020, 5:40 PM.
Tags
None
Referenced Files
F18824463: D21085.id.diff
Thu, Oct 23, 3:51 PM
F18821996: D21085.diff
Thu, Oct 23, 3:25 AM
F18774245: D21085.diff
Thu, Oct 9, 6:06 PM
F18602946: D21085.diff
Sep 13 2025, 4:16 PM
F18596115: D21085.diff
Sep 12 2025, 11:44 PM
F18593629: D21085.diff
Sep 12 2025, 3:27 PM
F18567738: D21085.id.diff
Sep 9 2025, 4:08 PM
F18442812: D21085.id50226.diff
Aug 31 2025, 6:16 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13490: Upgrade all "classic" Arcanist workflows to Toolsets
Commits
rARCccd1ebb25686: Port "arc prompts" from wilds and fix a path issue in shell completion
Summary

Ref T13490. Bring "arc prompts" from "wilds" and hook it into the prompt in "arc shell-complete".

See D21069. Fix an issue where the shell hook tested for a path other than the path it writes to.

Test Plan

Ran "arc shell-complete" with no hook and got a prompt. Shell completed things. Ran "arc prompts shell-complete".

Diff Detail

Repository
rARC Arcanist
Branch
prompt1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 24044
Build 33097: Run Core Tests
Build 33096: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
toolset/
workflow/
80 lines
5 lines
workflow/
60 lines
support/
shell/
hooks/
5 lines

Diff 50226

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/toolset/workflow/ArcanistPromptsWorkflow.php

Loading...
View Options

src/toolset/workflow/ArcanistShellCompleteWorkflow.php

Loading...
View Options

src/workflow/ArcanistWorkflow.php

Loading...
View Options

support/shell/hooks/bash-completion.sh

Loading...
Phabricator · Built by Phacility