Page MenuHomePhabricator
Differential D21085

Port "arc prompts" from wilds and fix a path issue in shell completion
ClosedPublic
Actions

Authored by epriestley on Apr 11 2020, 5:40 PM.
Tags
None
Referenced Files
F14403395: D21085.diff
Mon, Dec 23, 2:26 AM
Unknown Object (File)
Wed, Dec 18, 2:03 PM
Unknown Object (File)
Sat, Dec 7, 2:11 PM
Unknown Object (File)
Nov 11 2024, 9:41 AM
Unknown Object (File)
Oct 9 2024, 1:10 PM
Unknown Object (File)
Sep 21 2024, 12:20 AM
Unknown Object (File)
Sep 9 2024, 10:32 PM
Unknown Object (File)
Sep 6 2024, 7:17 AM
View All 81 Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13490: Upgrade all "classic" Arcanist workflows to Toolsets
Commits
rARCccd1ebb25686: Port "arc prompts" from wilds and fix a path issue in shell completion
Summary

Ref T13490. Bring "arc prompts" from "wilds" and hook it into the prompt in "arc shell-complete".

See D21069. Fix an issue where the shell hook tested for a path other than the path it writes to.

Test Plan

Ran "arc shell-complete" with no hook and got a prompt. Shell completed things. Ran "arc prompts shell-complete".

Diff Detail

Repository
rARC Arcanist
Branch
prompt1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 24044
Build 33097: Run Core Tests
Build 33096: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
toolset/
workflow/
80 lines
5 lines
workflow/
60 lines
support/
shell/
hooks/
5 lines

Diff 50226

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/toolset/workflow/ArcanistPromptsWorkflow.php

Loading...
View Options

src/toolset/workflow/ArcanistShellCompleteWorkflow.php

Loading...
View Options

src/workflow/ArcanistWorkflow.php

Loading...
View Options

support/shell/hooks/bash-completion.sh

Loading...
Phabricator · Built by Phacility