Diffusion Phabricator 58fbf64a2786

Refine handling of "@task" attributes in Diviner
58fbf64a2786
Actions

Tags

None

Referenced Files

None

Subscribers

None

Description

Refine handling of "@task" attributes in Diviner

Summary: Ref T13505. See that task for details. When a class has exactly one "@task" block, this API returns a string. Some day, this should be made more consistent.

Test Plan: Viewed a class with exactly one "@task", no more fatal. Viewed classes with zero and more than one "@task" attributes, got clean renderings.

Maniphest Tasks: T13505

Differential Revision: https://secure.phabricator.com/D21062

Details

Provenance

epriestley	Authored on Apr 6 2020, 6:47 PM
epriestley	Pushed on Apr 6 2020, 6:51 PM

Differential Revision

D21062: Refine handling of "@task" attributes in Diviner

Parents

rP271e104c7ea4: Update DivinerAtomController for a long-ago change to the docblock parser API

Branches

Unknown

Tags

Unknown

Tasks

T13505: Some Diviner pages on secure.phabricator.com show "RuntimeException: strlen() expects parameter 1 to be string, array given"

Build Status

Buildable 24000
Build 33030: Run Core Tests

Event Timeline

epriestley committed rP58fbf64a2786: Refine handling of "@task" attributes in Diviner (authored by epriestley).Apr 6 2020, 6:51 PM

epriestley added a task: T13505: Some Diviner pages on secure.phabricator.com show "RuntimeException: strlen() expects parameter 1 to be string, array given".

epriestley added an edge: D21062: Refine handling of "@task" attributes in Diviner.

Harbormaster completed building B24000: rP58fbf64a2786: Refine handling of "@task" attributes in Diviner.Apr 6 2020, 6:52 PM

Changes (1)

Path

Size

src/

applications/

diviner/

controller/

DivinerAtomController.php

rP58fbf64a2786

src/applications/diviner/controller/DivinerAtomController.php

Loading...