Page MenuHomePhabricator

Remove onboard future bulk-resolution from ConduitEngine
ClosedPublic

Authored by epriestley on Apr 8 2020, 3:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 21, 5:02 PM
Unknown Object (File)
Sun, Nov 17, 1:42 AM
Unknown Object (File)
Mon, Nov 4, 1:13 AM
Unknown Object (File)
Tue, Oct 29, 5:06 PM
Unknown Object (File)
Oct 17 2024, 2:40 AM
Unknown Object (File)
Oct 15 2024, 12:32 PM
Unknown Object (File)
Oct 14 2024, 5:09 PM
Unknown Object (File)
Oct 9 2024, 1:07 PM
Subscribers
None

Details

Summary

Depends on D21071. Ref T11968. Currently, "ConduitEngine" tries to lightly parallelize futures. This was a compromise when the initial "hardpoint" change didn't plan to pursue real request paralleization.

Now that the newer hardpoint change does, we don't need onboard resolution in ConduitEngine. Throw it away.

When the engine is supposed to resolve a future, it now just resolves that future on its own. This should be functionally identical to the previous behavior, except that it may be slower.

(In practice, because HTTP futures are backed by an internal cURL request pool, this proably has little effect anywhere. Moving to modern hardpoints will make performance no worse than it was prior to this change, in any case.)

Test Plan

Ran various modern "arc" commands.

Diff Detail

Repository
rARC Arcanist
Branch
ref3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24015
Build 33054: Run Core Tests
Build 33053: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Apr 8 2020, 4:24 PM
This revision was automatically updated to reflect the committed changes.