Page MenuHomePhabricator
Differential D21052

Update some ancient "set X=Y" environment code for new Windows execution without a shell
ClosedPublic
Actions

Authored by epriestley on Apr 2 2020, 8:43 PM.
Tags
None
Referenced Files
F13158028: D21052.diff
Sun, May 5, 4:10 PM
Unknown Object (File)
Thu, Apr 25, 2:13 AM
Unknown Object (File)
Wed, Apr 10, 9:29 PM
Unknown Object (File)
Mar 30 2024, 9:09 AM
Unknown Object (File)
Mar 29 2024, 3:10 AM
Unknown Object (File)
Mar 28 2024, 9:36 PM
Unknown Object (File)
Feb 15 2024, 1:17 PM
Unknown Object (File)
Feb 12 2024, 3:44 PM
View All 66 Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13209: How To Properly Escape Commands on Windows (A Dark Tragedy)
T13504: "proc_open()" may fail to return a resource on Windows if the command isn't executable
Commits
rARC368aec16a1ee: Update some ancient "set X=Y" environment code for new Windows execution…
Summary

Depends on D21051. Ref T13504. Ref T13209. This very old Mercurial code uses "X=Y hg ..." on Linux and "set X=Y & hg ..." on Windows.

The latter construct no longer works because we bypass the shell. The former construct is obsolete.

Additionaly, delete some ancient "branch merge" code which has no callers.

Test Plan

Created a diff in a Mercurial repository on Linux. I minimally vetted this on Windows since I don't have a "hg + Windows" environment at the moment.

Diff Detail

Repository
rARC Arcanist
Branch
windows3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23972
Build 32990: Run Core Tests
Build 32989: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 2 2020, 8:43 PM
Harbormaster completed remote builds in B23972: Diff 50153.Apr 2 2020, 8:44 PM
epriestley requested review of this revision.Apr 2 2020, 8:44 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 2 2020, 8:51 PM
Closed by commit rARC368aec16a1ee: Update some ancient "set X=Y" environment code for new Windows execution… (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rARC368aec16a1ee: Update some ancient "set X=Y" environment code for new Windows execution….

Revision Contents
Changeset List

Diff 50153

View Options

src/repository/api/ArcanistGitAPI.php

Loading...
View Options

src/repository/api/ArcanistMercurialAPI.php

Loading...
View Options

src/repository/api/ArcanistRepositoryAPI.php

Loading...
View Options

src/repository/api/ArcanistSubversionAPI.php

Loading...
Phabricator · Built by Phacility