Page MenuHomePhabricator

Collapse Arcanist toolsets from "wilds" into "master", as an overlay layer
ClosedPublic

Authored by epriestley on Feb 13 2020, 9:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 16, 11:14 PM
Unknown Object (File)
Tue, Apr 9, 2:35 PM
Unknown Object (File)
Sun, Apr 7, 5:39 PM
Unknown Object (File)
Sat, Apr 6, 2:43 AM
Unknown Object (File)
Sat, Mar 30, 8:56 AM
Unknown Object (File)
Sat, Mar 30, 8:56 AM
Unknown Object (File)
Sat, Mar 30, 8:56 AM
Unknown Object (File)
Sat, Mar 30, 8:56 AM
Subscribers
None

Details

Summary

Depends on D20988. Ref T13395. Ref T13098. Ref T13203.

This brings all the "toolsets" code into "master". We try to run commands as toolsets commands first, then fall back to older code.

Since the "toolsets" class tree is mostly parallel to the older class tree, this isn't completely broken. Currently, all commands fall back.

Test Plan

Created this diff, ran various other commands. But this is probably a long shot from finished.

Diff Detail

Repository
rARC Arcanist
Branch
wmerge2
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/runtime/ArcanistRuntime.php:317XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 23838
Build 32791: Run Core Tests
Build 32790: arc lint + arc unit

Event Timeline

epriestley created this revision.
  • Remove special casing for "ArcanistRuntime"; this class can load normally after bootstrapping.
  • Simplify some init-sequence wrangling and explicitly require PHP 5.5.0.
This revision was not accepted when it landed; it landed in state Needs Review.Feb 13 2020, 10:10 PM
This revision was automatically updated to reflect the committed changes.