Page MenuHomePhabricator

Collapse Arcanist toolsets from "wilds" into "master", as an overlay layer

Authored by epriestley on Feb 13 2020, 9:54 PM.



Depends on D20988. Ref T13395. Ref T13098. Ref T13203.

This brings all the "toolsets" code into "master". We try to run commands as toolsets commands first, then fall back to older code.

Since the "toolsets" class tree is mostly parallel to the older class tree, this isn't completely broken. Currently, all commands fall back.

Test Plan

Created this diff, ran various other commands. But this is probably a long shot from finished.

Diff Detail

rARC Arcanist
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley updated this revision to Diff 50013.Feb 13 2020, 9:54 PM
epriestley created this revision.
  • Remove special casing for "ArcanistRuntime"; this class can load normally after bootstrapping.
Harbormaster completed remote builds in B23839: Diff 50013.
epriestley requested review of this revision.Feb 13 2020, 9:55 PM
  • Simplify some init-sequence wrangling and explicitly require PHP 5.5.0.
This revision was not accepted when it landed; it landed in state Needs Review.Feb 13 2020, 10:10 PM
This revision was automatically updated to reflect the committed changes.