Page MenuHomePhabricator
Differential D20989

Don't depend on "XMLWriter" to load the lint renderer class tree
ClosedPublic
Actions

Authored by epriestley on Feb 13 2020, 9:37 PM.
Tags
None
Referenced Files
F15433953: D20989.id.diff
Tue, Mar 25, 1:21 AM
F15432016: D20989.id.diff
Mon, Mar 24, 3:51 PM
F15377089: D20989.diff
Thu, Mar 13, 7:56 AM
F15376242: D20989.id50010.diff
Thu, Mar 13, 2:19 AM
F15340644: D20989.diff
Sun, Mar 9, 3:58 PM
Unknown Object (File)
Thu, Feb 27, 1:54 PM
Unknown Object (File)
Feb 14 2025, 1:27 AM
Unknown Object (File)
Feb 9 2025, 8:41 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13489: Fix implicit "XMLWriter" requirement when loading lint sinks
Commits
rARC0d62a10eda68: Don't depend on "XMLWriter" to load the lint renderer class tree
Summary

Fixes T13489. See that task for discussion.

Test Plan

Ran arc lint and arc lint --output xml. Faked a missing extension, ran arc lint (no problems) and arc lint --output xml (sensible error message).

Diff Detail

Repository
rARC Arcanist
Branch
xml1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23836
Build 32788: Run Core Tests
Build 32787: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 13 2020, 9:37 PM
Harbormaster completed remote builds in B23836: Diff 50010.Feb 13 2020, 9:38 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 13 2020, 9:38 PM
epriestley requested review of this revision.
Closed by commit rARC0d62a10eda68: Don't depend on "XMLWriter" to load the lint renderer class tree (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rARC0d62a10eda68: Don't depend on "XMLWriter" to load the lint renderer class tree.

Revision Contents
Changeset List

PathSize
src/
lint/
renderer/
70 lines

Diff 50010

View Options

src/lint/renderer/ArcanistCheckstyleXMLLintRenderer.php

Loading...
Phabricator · Built by Phacility