Differential D20978

Move HTML-only intraline diff code to Phabricator
ClosedPublic
Actions

Authored by epriestley on Feb 12 2020, 8:30 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Feb 9, 8:37 AM

	Unknown Object (File)
	Sun, Feb 9, 8:37 AM

	Unknown Object (File)
	Sun, Feb 9, 8:36 AM

	Unknown Object (File)
	Wed, Jan 29, 6:36 PM

	Unknown Object (File)
	Tue, Jan 28, 5:25 AM

	Unknown Object (File)
	Sun, Jan 26, 7:34 PM

	Unknown Object (File)
	Sat, Jan 25, 6:28 AM

	Unknown Object (File)
	Sat, Jan 25, 6:28 AM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13395: Strip libphutil for parts
Commits: rARCa36e60f0a37e: Move HTML-only intraline diff code to Phabricator

Summary

Ref T13395. This code relies on PhutilHTML, but that's moving to Phabricator.

It has no callers in libphutil or Arcanist.

Test Plan

Looked for callers.

Diff Detail

Repository

rARC Arcanist

Branch

strip4

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23811
Build 32750: Run Core Tests
Build 32749: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 12 2020, 8:30 PM

Harbormaster completed remote builds in B23811: Diff 49985.Feb 12 2020, 8:30 PM

epriestley requested review of this revision.Feb 12 2020, 8:30 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 12 2020, 9:13 PM

Closed by commit rARCa36e60f0a37e: Move HTML-only intraline diff code to Phabricator (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARCa36e60f0a37e: Move HTML-only intraline diff code to Phabricator.

Revision Contents
Changeset List

Path

Size

src/

difference/

ArcanistDiffUtils.php

89 lines

Diff 49985

View Options

src/difference/ArcanistDiffUtils.php

Move HTML-only intraline diff code to PhabricatorClosedPublicActions