Differential D20970

In summary interfaces, don't render very large inline remarkup details for unit test messages
ClosedPublic
Actions

Authored by epriestley on Feb 5 2020, 3:45 PM.

Details

Reviewers: None
Maniphest Tasks: T10635: Loading differential revision slow when lots of unit test messages exist
Commits: rP9d1af762d518: In summary interfaces, don't render very large inline remarkup details for unit…

Summary

Ref T10635. An install with large blocks of remarkup (4MB) in test details is reporting slow page rendering. This is expected, but I've mostly given up on fighting this unless I absolutely have to. Degrade the interface more aggressively.

Test Plan

Submitted a large block of test details in remarkup format.
Before patch: they rendered inline.
After patch: degraded display.
Verified small blocks are not changed.

Screen Shot 2020-02-05 at 7.36.00 AM.png (1×1 px, 292 KB)

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 5 2020, 3:45 PM

Owners added a subscriber: Restricted Owners Package.Feb 5 2020, 3:45 PM

Harbormaster completed remote builds in B23791: Diff 49966.Feb 5 2020, 3:46 PM

epriestley requested review of this revision.Feb 5 2020, 3:46 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 5 2020, 10:26 PM

Closed by commit rP9d1af762d518: In summary interfaces, don't render very large inline remarkup details for unit… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP9d1af762d518: In summary interfaces, don't render very large inline remarkup details for unit….

Revision Contents
Changeset List

Path

Size

src/

applications/

harbormaster/

storage/

build/

HarbormasterBuildUnitMessage.php

84 lines

view/

HarbormasterUnitPropertyView.php

6 lines

Diff 49967

View Options

src/applications/harbormaster/storage/build/HarbormasterBuildUnitMessage.php