Page MenuHomePhabricator

In summary interfaces, don't render very large inline remarkup details for unit test messages
ClosedPublic

Authored by epriestley on Feb 5 2020, 3:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 21, 1:19 AM
Unknown Object (File)
Sun, Mar 17, 9:06 AM
Unknown Object (File)
Sat, Mar 16, 11:22 AM
Unknown Object (File)
Thu, Mar 14, 6:05 PM
Unknown Object (File)
Fri, Mar 1, 5:46 AM
Unknown Object (File)
Fri, Mar 1, 5:46 AM
Unknown Object (File)
Fri, Mar 1, 5:46 AM
Unknown Object (File)
Feb 22 2024, 9:07 PM
Subscribers
Restricted Owners Package

Details

Summary

Ref T10635. An install with large blocks of remarkup (4MB) in test details is reporting slow page rendering. This is expected, but I've mostly given up on fighting this unless I absolutely have to. Degrade the interface more aggressively.

Test Plan
  • Submitted a large block of test details in remarkup format.
  • Before patch: they rendered inline.
  • After patch: degraded display.
  • Verified small blocks are not changed.

Screen Shot 2020-02-05 at 7.36.10 AM.png (99×1 px, 13 KB)

Screen Shot 2020-02-05 at 7.36.00 AM.png (1×1 px, 292 KB)

Diff Detail

Repository
rP Phabricator
Branch
unit1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23791
Build 32718: Run Core Tests
Build 32717: arc lint + arc unit

Event Timeline

Owners added a subscriber: Restricted Owners Package.Feb 5 2020, 3:45 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 5 2020, 10:26 PM
This revision was automatically updated to reflect the committed changes.