Differential D20939

Move search query parser/compiler classes to Phabricator
ClosedPublic
Actions

Authored by epriestley on Jan 14 2020, 7:41 PM.

Details

Reviewers: None
Maniphest Tasks: T13395: Strip libphutil for parts
T13472: Porter stemmer library uses obsolete array access syntax which raises warning under PHP 7.4
Commits: rP767528c0ed55: Move search query parser/compiler classes to Phabricator

Summary

Ref T13472. Ref T13395. These classes are only used by Phabricator and not likely to find much use in Arcanist.

Test Plan

Grepped libphutil and Arcanist for removed symbols.

Diff Detail

Repository

rP Phabricator

Branch

stem1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23717
Build 32610: Run Core Tests
Build 32609: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 14 2020, 7:41 PM

Harbormaster completed remote builds in B23717: Diff 49891.Jan 14 2020, 7:42 PM

epriestley requested review of this revision.Jan 14 2020, 7:42 PM

Also move the Porter stemmer.
Ran some search queries.

epriestley mentioned this in D20940: Move search query compiler / stemmer classes out of libphutil.Jan 14 2020, 7:48 PM

Harbormaster completed remote builds in B23718: Diff 49892.Jan 14 2020, 7:49 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jan 14 2020, 7:49 PM

Closed by commit rP767528c0ed55: Move search query parser/compiler classes to Phabricator (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in rPHUcc2a3dbf5903: Move search query compiler / stemmer classes out of libphutil.

epriestley added a commit: rP767528c0ed55: Move search query parser/compiler classes to Phabricator.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

applications/

search/

compiler/

PhutilSearchQueryCompiler.php

374 lines

PhutilSearchQueryCompilerSyntaxException.php

4 lines

PhutilSearchQueryToken.php

37 lines

PhutilSearchStemmer.php

74 lines

__tests__/

PhutilSearchQueryCompilerTestCase.php

220 lines

PhutilSearchStemmerTestCase.php

85 lines

Diff 49891

View Options

src/__phutil_library_map__.php

View Options

src/applications/search/compiler/PhutilSearchQueryCompiler.php

View Options

src/applications/search/compiler/PhutilSearchQueryCompilerSyntaxException.php

View Options

src/applications/search/compiler/PhutilSearchQueryToken.php

View Options

src/applications/search/compiler/PhutilSearchStemmer.php

View Options

src/applications/search/compiler/tests/PhutilSearchQueryCompilerTestCase.php

View Options

src/applications/search/compiler/tests/PhutilSearchStemmerTestCase.php

Move search query parser/compiler classes to PhabricatorClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 49891

src/__phutil_library_map__.php

src/applications/search/compiler/PhutilSearchQueryCompiler.php

src/applications/search/compiler/PhutilSearchQueryCompilerSyntaxException.php

src/applications/search/compiler/PhutilSearchQueryToken.php

src/applications/search/compiler/PhutilSearchStemmer.php

src/applications/search/compiler/__tests__/PhutilSearchQueryCompilerTestCase.php

src/applications/search/compiler/__tests__/PhutilSearchStemmerTestCase.php

Move search query parser/compiler classes to Phabricator
ClosedPublic
Actions

Revision Contents
Changeset List

src/applications/search/compiler/tests/PhutilSearchQueryCompilerTestCase.php

src/applications/search/compiler/tests/PhutilSearchStemmerTestCase.php