Page MenuHomePhabricator

Fix an issue where editing paths in Owners packages could raise an error: undefined index "display"
ClosedPublic

Authored by epriestley on Nov 21 2019, 7:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 8, 3:56 AM
Unknown Object (File)
Feb 20 2024, 2:39 AM
Unknown Object (File)
Dec 25 2023, 6:10 PM
Unknown Object (File)
Dec 14 2023, 4:09 PM
Unknown Object (File)
Nov 25 2023, 10:50 PM
Unknown Object (File)
Nov 25 2023, 4:49 PM
Unknown Object (File)
Oct 31 2023, 3:15 AM
Unknown Object (File)
Oct 20 2023, 1:54 PM
Subscribers
None

Details

Summary

Fixes T13464. Fully-realized paths have a "path" (normalized, effective path) and a "display" path (user-facing, un-normalized path).

During transaction validation we build ref keys for paths before we normalize the "display" values. A few different approaches could be taken to resolve this, but just default the "display" path to the raw "path" if it isn't present since that seems simplest.

Test Plan

Edited paths in an Owners package, no longer saw a warning in the logs.

Diff Detail

Repository
rP Phabricator
Branch
owners1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23692
Build 32573: Run Core Tests
Build 32572: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Nov 21 2019, 7:28 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.