Page MenuHomePhabricator

Make repository identity email address association case-insensitive
ClosedPublic

Authored by epriestley on Nov 14 2019, 3:15 AM.
Tags
None
Referenced Files
F12805029: D20907.id49851.diff
Wed, Mar 27, 4:55 PM
Unknown Object (File)
Thu, Mar 21, 1:42 AM
Unknown Object (File)
Fri, Mar 8, 3:41 AM
Unknown Object (File)
Wed, Mar 6, 1:52 AM
Unknown Object (File)
Feb 21 2024, 4:14 PM
Unknown Object (File)
Feb 21 2024, 6:02 AM
Unknown Object (File)
Feb 6 2024, 4:34 PM
Unknown Object (File)
Dec 23 2023, 5:31 AM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13444. Currently, identities for a particular email address are queried with "LIKE" against a binary column, which makes the query case-sensitive.

  • Extract the email address into a separate "sort255" column.
  • Add a key for it.
  • Make the query a standard "IN (%Ls)" query.
  • Deal with weird cases where an email address is 10000 bytes long or full of binary junk.
Test Plan
  • Ran migration, inspected database for general sanity.
  • Ran query script in T13444, saw it return the same hits for "git@" and "GIT@".

Diff Detail

Repository
rP Phabricator
Branch
identity1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23657
Build 32522: Run Core Tests
Build 32521: arc lint + arc unit

Event Timeline

Owners added a subscriber: Restricted Owners Package.Nov 14 2019, 3:15 AM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 19 2019, 5:37 PM
This revision was automatically updated to reflect the committed changes.