Differential D20907

Make repository identity email address association case-insensitive
ClosedPublic
Actions

Authored by epriestley on Nov 14 2019, 3:15 AM.

Tags

None

Referenced Files

	F14093557: D20907.diff
	Mon, Nov 25, 11:51 AM

	Unknown Object (File)
	Sat, Nov 23, 5:33 AM

	Unknown Object (File)
	Mon, Nov 11, 8:14 PM

	Unknown Object (File)
	Mon, Nov 4, 12:40 AM

	Unknown Object (File)
	Fri, Nov 1, 5:11 AM

	Unknown Object (File)
	Oct 22 2024, 10:17 PM

	Unknown Object (File)
	Oct 22 2024, 12:13 AM

	Unknown Object (File)
	Oct 21 2024, 3:18 AM

Subscribers

Restricted Owners Package

Details

Reviewers: None
Maniphest Tasks: T13444: Provide a standalone script entry point for resolving a repository identity
Commits: rPdf0f5c6cee03: Make repository identity email address association case-insensitive

Summary

Ref T13444. Currently, identities for a particular email address are queried with "LIKE" against a binary column, which makes the query case-sensitive.

Extract the email address into a separate "sort255" column.
Add a key for it.
Make the query a standard "IN (%Ls)" query.
Deal with weird cases where an email address is 10000 bytes long or full of binary junk.

Test Plan

Ran migration, inspected database for general sanity.
Ran query script in T13444, saw it return the same hits for "git@" and "GIT@".

Diff Detail

Repository

Branch

identity1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23657
Build 32522: Run Core Tests
Build 32521: arc lint + arc unit

Event Timeline

epriestley created this revision.Nov 14 2019, 3:15 AM

Owners added a subscriber: Restricted Owners Package.Nov 14 2019, 3:15 AM

Harbormaster completed remote builds in B23657: Diff 49829.Nov 14 2019, 3:17 AM

epriestley requested review of this revision.Nov 14 2019, 3:17 AM

This revision was not accepted when it landed; it landed in state Needs Review.Nov 19 2019, 5:37 PM

Closed by commit rPdf0f5c6cee03: Make repository identity email address association case-insensitive (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPdf0f5c6cee03: Make repository identity email address association case-insensitive.

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20191113.identity.01.email.sql

2 lines

20191113.identity.02.populate.php

26 lines

src/

applications/

diffusion/

controller/

DiffusionIdentityViewController.php

15 lines

DiffusionRepositoryListController.php

8 lines

repository/

query/

PhabricatorRepositoryIdentityQuery.php

13 lines

storage/

PhabricatorRepositoryIdentity.php

31 lines

worker/

PhabricatorRepositoryIdentityChangeWorker.php

2 lines

Diff 49829

resources/sql/autopatches/20191113.identity.01.email.sql

Loading...

resources/sql/autopatches/20191113.identity.02.populate.php

Loading...

src/applications/diffusion/controller/DiffusionIdentityViewController.php

Loading...

src/applications/diffusion/controller/DiffusionRepositoryListController.php

Loading...

src/applications/repository/query/PhabricatorRepositoryIdentityQuery.php

Loading...

src/applications/repository/storage/PhabricatorRepositoryIdentity.php

Loading...

src/applications/repository/worker/PhabricatorRepositoryIdentityChangeWorker.php

Loading...