Page MenuHomePhabricator
Differential D20900

Update various Asana odds-and-ends for "gid" API changes
ClosedPublic
Actions

Authored by epriestley on Nov 8 2019, 5:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Feb 12, 4:13 AM
Unknown Object (File)
Wed, Feb 12, 4:13 AM
Unknown Object (File)
Wed, Feb 12, 4:13 AM
Unknown Object (File)
Mon, Feb 10, 10:54 AM
Unknown Object (File)
Sun, Feb 9, 8:26 AM
Unknown Object (File)
Sun, Feb 9, 8:26 AM
Unknown Object (File)
Sun, Feb 9, 8:25 AM
Unknown Object (File)
Wed, Jan 29, 10:38 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13453: Update Asana Auth Adapter for "gid" API changes
Commits
rPcd60a8aa563b: Update various Asana odds-and-ends for "gid" API changes
Summary

Ref T13453. Some of the Asana integrations also need API updates.

Depends on D20899.

Test Plan
  • Viewed "asana.workspace-id" in Config, got a sensible GID list.
  • Created a revision, saw the associated Asana task get assigned.
  • Pasted an Asana link I could view into a revision description, saw it Doorkeeper in the metadata.

Diff Detail

Repository
rP Phabricator
Branch
asana2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23642
Build 32501: Run Core Tests
Build 32500: arc lint + arc unit

Event Timeline

epriestley created this revision.Nov 8 2019, 5:01 PM
Harbormaster completed remote builds in B23642: Diff 49814.Nov 8 2019, 5:03 PM
epriestley requested review of this revision.Nov 8 2019, 5:03 PM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 8 2019, 5:08 PM
Closed by commit rPcd60a8aa563b: Update various Asana odds-and-ends for "gid" API changes (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rPcd60a8aa563b: Update various Asana odds-and-ends for "gid" API changes.

Revision Contents
Changeset List

PathSize
src/
applications/
doorkeeper/
bridge/
7 lines
option/
5 lines
worker/
8 lines

Diff 49814

View Options

src/applications/doorkeeper/bridge/DoorkeeperBridgeAsana.php

Loading...
View Options

src/applications/doorkeeper/option/PhabricatorAsanaConfigOptions.php

Loading...
View Options

src/applications/doorkeeper/worker/DoorkeeperAsanaFeedWorker.php

Loading...
Phabricator · Built by Phacility