Differential D20899

Update Asana Auth adapter for "gid" API changes
ClosedPublic
Actions

Authored by epriestley on Nov 8 2019, 4:59 PM.

Details

Reviewers: None
Maniphest Tasks: T13453: Update Asana Auth Adapter for "gid" API changes
Commits: rP2223d6b91467: Update Asana Auth adapter for "gid" API changes

Summary

Ref T13453. The Asana API has changed, replacing all "id" fields with "gid", including the "users/me" API call result.

Test Plan

Linked an Asana account. Before: error about missing 'id'. After: clean link.

Diff Detail

Repository

rP Phabricator

Branch

asana1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23641
Build 32499: Run Core Tests
Build 32498: arc lint + arc unit

Event Timeline

epriestley created this revision.Nov 8 2019, 4:59 PM

Harbormaster completed remote builds in B23641: Diff 49813.Nov 8 2019, 5:01 PM

epriestley requested review of this revision.Nov 8 2019, 5:01 PM

epriestley added a child revision: D20900: Update various Asana odds-and-ends for "gid" API changes.Nov 8 2019, 5:01 PM

This revision was not accepted when it landed; it landed in state Needs Review.Nov 8 2019, 5:02 PM

Closed by commit rP2223d6b91467: Update Asana Auth adapter for "gid" API changes (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP2223d6b91467: Update Asana Auth adapter for "gid" API changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

auth/

adapter/

PhutilAsanaAuthAdapter.php

4 lines

Diff 49813

View Options

src/applications/auth/adapter/PhutilAsanaAuthAdapter.php

Update Asana Auth adapter for "gid" API changesClosedPublicActions