Page MenuHomePhabricator

When fetching Git repositories, pass "--no-tags" to make explicit "Fetch Refs" operate more narrowly
ClosedPublic

Authored by epriestley on Thu, Nov 7, 11:51 PM.

Details

Summary

Ref T13448. The default behavior of "git fetch '+refs/heads/master:refs/heads/master'" is to follow and fetch associated tags.

We don't want this when we pass a narrow refspec because of "Fetch Refs" configuration. Tell Git that we only want the refs we explicitly passed.

Note that this doesn't prevent us from fetching tags (if the refspec specifies them), it just stops us from fetching extra tags that aren't part of the refspec.

Test Plan
  • Ran "bin/repository pull X --trace --verbose" in a repository with a "Fetch Refs" configuration, saw only "master" get fetched (previously: "master" and reachable tags).
  • Ran "git fetch --no-tags '+refs/*:refs/*'", saw tags fetched normally ("--no-tags" does not disable fetching tags).

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Thu, Nov 7, 11:51 PM
epriestley requested review of this revision.Thu, Nov 7, 11:53 PM
This revision was not accepted when it landed; it landed in state Needs Review.Fri, Nov 8, 12:17 AM
This revision was automatically updated to reflect the committed changes.