Page MenuHomePhabricator

When fetching Git repositories, pass "--no-tags" to make explicit "Fetch Refs" operate more narrowly
ClosedPublic

Authored by epriestley on Nov 7 2019, 11:51 PM.
Tags
None
Referenced Files
F14091693: D20893.id49800.diff
Mon, Nov 25, 1:32 AM
Unknown Object (File)
Fri, Nov 22, 6:48 PM
Unknown Object (File)
Oct 18 2024, 1:16 PM
Unknown Object (File)
Oct 15 2024, 8:47 AM
Unknown Object (File)
Oct 15 2024, 7:03 AM
Unknown Object (File)
Sep 20 2024, 4:28 PM
Unknown Object (File)
Sep 20 2024, 4:26 PM
Unknown Object (File)
Sep 20 2024, 4:25 PM
Subscribers
None

Details

Summary

Ref T13448. The default behavior of "git fetch '+refs/heads/master:refs/heads/master'" is to follow and fetch associated tags.

We don't want this when we pass a narrow refspec because of "Fetch Refs" configuration. Tell Git that we only want the refs we explicitly passed.

Note that this doesn't prevent us from fetching tags (if the refspec specifies them), it just stops us from fetching extra tags that aren't part of the refspec.

Test Plan
  • Ran "bin/repository pull X --trace --verbose" in a repository with a "Fetch Refs" configuration, saw only "master" get fetched (previously: "master" and reachable tags).
  • Ran "git fetch --no-tags '+refs/*:refs/*'", saw tags fetched normally ("--no-tags" does not disable fetching tags).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable