Page MenuHomePhabricator

When fetching Git repositories, pass "--no-tags" to make explicit "Fetch Refs" operate more narrowly
ClosedPublic

Authored by epriestley on Nov 7 2019, 11:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 20, 5:38 PM
Unknown Object (File)
Wed, Dec 18, 5:13 PM
Unknown Object (File)
Sun, Dec 15, 7:33 AM
Unknown Object (File)
Thu, Dec 12, 10:45 AM
Unknown Object (File)
Wed, Dec 11, 3:30 AM
Unknown Object (File)
Tue, Dec 10, 7:08 AM
Unknown Object (File)
Thu, Dec 5, 12:17 AM
Unknown Object (File)
Tue, Dec 3, 9:30 PM
Subscribers
None

Details

Summary

Ref T13448. The default behavior of "git fetch '+refs/heads/master:refs/heads/master'" is to follow and fetch associated tags.

We don't want this when we pass a narrow refspec because of "Fetch Refs" configuration. Tell Git that we only want the refs we explicitly passed.

Note that this doesn't prevent us from fetching tags (if the refspec specifies them), it just stops us from fetching extra tags that aren't part of the refspec.

Test Plan
  • Ran "bin/repository pull X --trace --verbose" in a repository with a "Fetch Refs" configuration, saw only "master" get fetched (previously: "master" and reachable tags).
  • Ran "git fetch --no-tags '+refs/*:refs/*'", saw tags fetched normally ("--no-tags" does not disable fetching tags).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable