Differential D20893

When fetching Git repositories, pass "--no-tags" to make explicit "Fetch Refs" operate more narrowly
ClosedPublic
Actions

Authored by epriestley on Nov 7 2019, 11:51 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Nov 26, 5:47 PM

	Unknown Object (File)
	Mon, Nov 25, 9:25 PM

	Unknown Object (File)
	Mon, Nov 25, 1:32 AM

	Unknown Object (File)
	Fri, Nov 22, 6:48 PM

	Unknown Object (File)
	Oct 18 2024, 1:16 PM

	Unknown Object (File)
	Oct 15 2024, 8:47 AM

	Unknown Object (File)
	Oct 15 2024, 7:03 AM

	Unknown Object (File)
	Sep 20 2024, 4:28 PM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13448: Respect "Fetch Refs" when cloning a new repository
Commits: rP8dd57a1ed221: When fetching Git repositories, pass "--no-tags" to make explicit "Fetch Refs"…

Summary

Ref T13448. The default behavior of "git fetch '+refs/heads/master:refs/heads/master'" is to follow and fetch associated tags.

We don't want this when we pass a narrow refspec because of "Fetch Refs" configuration. Tell Git that we only want the refs we explicitly passed.

Note that this doesn't prevent us from fetching tags (if the refspec specifies them), it just stops us from fetching extra tags that aren't part of the refspec.

Test Plan

Ran "bin/repository pull X --trace --verbose" in a repository with a "Fetch Refs" configuration, saw only "master" get fetched (previously: "master" and reachable tags).
Ran "git fetch --no-tags '+refs/*:refs/*'", saw tags fetched normally ("--no-tags" does not disable fetching tags).

Diff Detail

Repository

Branch

refs2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23629
Build 32482: Run Core Tests
Build 32481: arc lint + arc unit

Event Timeline

epriestley created this revision.Nov 7 2019, 11:51 PM

Harbormaster completed remote builds in B23629: Diff 49800.Nov 7 2019, 11:53 PM

epriestley requested review of this revision.Nov 7 2019, 11:53 PM

This revision was not accepted when it landed; it landed in state Needs Review.Nov 8 2019, 12:17 AM

Closed by commit rP8dd57a1ed221: When fetching Git repositories, pass "--no-tags" to make explicit "Fetch Refs"… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP8dd57a1ed221: When fetching Git repositories, pass "--no-tags" to make explicit "Fetch Refs"….

Revision Contents
Changeset List

Path

Size

src/

applications/

repository/

engine/

PhabricatorRepositoryPullEngine.php

2 lines

Diff 49800

src/applications/repository/engine/PhabricatorRepositoryPullEngine.php

Loading...