Page MenuHomePhabricator

When fetching Git repositories, pass "--no-tags" to make explicit "Fetch Refs" operate more narrowly
ClosedPublic

Authored by epriestley on Nov 7 2019, 11:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 22, 11:35 PM
Unknown Object (File)
Tue, Mar 5, 11:20 AM
Unknown Object (File)
Feb 28 2024, 2:07 AM
Unknown Object (File)
Feb 13 2024, 7:24 AM
Unknown Object (File)
Feb 2 2024, 4:37 AM
Unknown Object (File)
Feb 1 2024, 1:44 PM
Unknown Object (File)
Jan 20 2024, 9:02 PM
Unknown Object (File)
Dec 19 2023, 7:24 PM
Subscribers
None

Details

Summary

Ref T13448. The default behavior of "git fetch '+refs/heads/master:refs/heads/master'" is to follow and fetch associated tags.

We don't want this when we pass a narrow refspec because of "Fetch Refs" configuration. Tell Git that we only want the refs we explicitly passed.

Note that this doesn't prevent us from fetching tags (if the refspec specifies them), it just stops us from fetching extra tags that aren't part of the refspec.

Test Plan
  • Ran "bin/repository pull X --trace --verbose" in a repository with a "Fetch Refs" configuration, saw only "master" get fetched (previously: "master" and reachable tags).
  • Ran "git fetch --no-tags '+refs/*:refs/*'", saw tags fetched normally ("--no-tags" does not disable fetching tags).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable