Differential D20887

Add an "Advanced/Developer..." action item for viewing object handle details and hovercards
ClosedPublic
Actions

Authored by epriestley on Nov 1 2019, 5:16 PM.

Details

Reviewers: None
Maniphest Tasks: T13157: Provide more advanced tools for developing against Phabricator and discovering PHIDs
T13442: Show more information on task hovercards (status, cover images)
Commits: rPb83b3224bb75: Add an "Advanced/Developer..." action item for viewing object handle details…

Summary

Ref T13442. Ref T13157. There's a secret URI to look at an object's hovercard in a standalone view, but it's hard to remember and impossible to discover.

In developer mode, add an action to "View Hovercard". Also add "View Handle", which primarily shows the object PHID.

Test Plan

Viewed some objects, saw "Advanced/Developer...". Used "View Hovercard" to view hovercards and "View Handle" to view handles.

Diff Detail

Repository

rP Phabricator

Branch

hover1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23620
Build 32468: Run Core Tests
Build 32467: arc lint + arc unit

Event Timeline

epriestley created this revision.Nov 1 2019, 5:16 PM

Harbormaster completed remote builds in B23620: Diff 49791.Nov 1 2019, 5:18 PM

epriestley requested review of this revision.Nov 1 2019, 5:18 PM

epriestley edited the summary of this revision. (Show Details)Nov 1 2019, 5:21 PM

epriestley added a task: T13157: Provide more advanced tools for developing against Phabricator and discovering PHIDs.

epriestley added a child revision: D20888: Show cover images on task hovercards.Nov 1 2019, 5:42 PM

This revision was not accepted when it landed; it landed in state Needs Review.Nov 9 2019, 12:47 AM

Closed by commit rPb83b3224bb75: Add an "Advanced/Developer..." action item for viewing object handle details… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPb83b3224bb75: Add an "Advanced/Developer..." action item for viewing object handle details….

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

applications/

search/

application/

PhabricatorSearchApplication.php

2 lines

controller/

PhabricatorSearchHandleController.php

89 lines

system/

application/

PhabricatorSystemApplication.php

6 lines

events/

PhabricatorSystemDebugUIEventListener.php

58 lines

view/

layout/

PhabricatorActionListView.php

8 lines

Diff 49791

View Options

src/__phutil_library_map__.php

View Options

src/applications/search/application/PhabricatorSearchApplication.php

View Options

src/applications/search/controller/PhabricatorSearchHandleController.php

View Options

src/applications/system/application/PhabricatorSystemApplication.php

View Options

src/applications/system/events/PhabricatorSystemDebugUIEventListener.php

View Options

src/view/layout/PhabricatorActionListView.php

Add an "Advanced/Developer..." action item for viewing object handle details and hovercardsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 49791

src/__phutil_library_map__.php

src/applications/search/application/PhabricatorSearchApplication.php

src/applications/search/controller/PhabricatorSearchHandleController.php

src/applications/system/application/PhabricatorSystemApplication.php

src/applications/system/events/PhabricatorSystemDebugUIEventListener.php

src/view/layout/PhabricatorActionListView.php

Add an "Advanced/Developer..." action item for viewing object handle details and hovercards
ClosedPublic
Actions

Revision Contents
Changeset List