Fixes T13437. This URI construction was just missing URI encoding.
Also, trim the symbol because my test case ended up catching "#define\n" as symbol text.
Details
Details
- Reviewers
- None
- Maniphest Tasks
- T13437: "Jump to Symbol" URIs from diff views are built without proper escaping
- Commits
- rPe1da1d86d680: Trim and URI encode symbol names before building URIs from them
- Configured a repository to have PHP symbols.
- Touched a ".php" file with "#define" in it.
- Diffed the change.
- Command-clicked "#define" in the UI, in Safari/MacOS, to jump to the definition.
- Before: taken to a nonsense page where "#define" became an anchor.
- After: taken to symbol search for "#define".
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- symbol1
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 23598 Build 32435: Run Core Tests Build 32434: arc lint + arc unit