Trim and URI encode symbol names before building URIs from them
ClosedPublic
Actions

Authored by epriestley on Oct 29 2019, 4:41 PM.

Details

Reviewers: None
Maniphest Tasks: T13437: "Jump to Symbol" URIs from diff views are built without proper escaping
Commits: rPe1da1d86d680: Trim and URI encode symbol names before building URIs from them

Summary

Fixes T13437. This URI construction was just missing URI encoding.

Also, trim the symbol because my test case ended up catching "#define\n" as symbol text.

Test Plan

Configured a repository to have PHP symbols.
Touched a ".php" file with "#define" in it.
Diffed the change.
Command-clicked "#define" in the UI, in Safari/MacOS, to jump to the definition.
- Before: taken to a nonsense page where "#define" became an anchor.
- After: taken to symbol search for "#define".

Repository

rP Phabricator

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

epriestley requested review of this revision.Oct 29 2019, 4:43 PM

This revision was not accepted when it landed; it landed in state Needs Review.Oct 29 2019, 4:48 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			resources/celerity/map.php (18 lines)
M			webroot/rsrc/js/application/repository/repository-crossreference.js (11 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	49769	4a53fc3		Oct 29 2019, 4:41 PM	★	★
Diff 2	49770	4a53fc3	rPe1da1d86d68021f7e69191e72f27e4293d2a0fe4	Oct 29 2019, 4:48 PM	★	★