Page MenuHomePhabricator

Trim and URI encode symbol names before building URIs from them
ClosedPublic

Authored by epriestley on Oct 29 2019, 4:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 8, 3:40 AM
Unknown Object (File)
Mon, Mar 4, 7:02 PM
Unknown Object (File)
Jan 25 2024, 7:29 AM
Unknown Object (File)
Jan 23 2024, 9:24 AM
Unknown Object (File)
Dec 15 2023, 4:13 PM
Unknown Object (File)
Dec 5 2023, 4:17 PM
Unknown Object (File)
Nov 13 2023, 6:15 AM
Unknown Object (File)
Nov 1 2023, 4:13 PM
Subscribers
None

Details

Summary

Fixes T13437. This URI construction was just missing URI encoding.

Also, trim the symbol because my test case ended up catching "#define\n" as symbol text.

Test Plan
  • Configured a repository to have PHP symbols.
  • Touched a ".php" file with "#define" in it.
  • Diffed the change.
  • Command-clicked "#define" in the UI, in Safari/MacOS, to jump to the definition.
    • Before: taken to a nonsense page where "#define" became an anchor.
    • After: taken to symbol search for "#define".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Oct 29 2019, 4:48 PM
This revision was automatically updated to reflect the committed changes.