Differential D20876

Trim and URI encode symbol names before building URIs from them
ClosedPublic
Actions

Authored by epriestley on Oct 29 2019, 4:41 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Dec 13, 9:06 AM

	Unknown Object (File)
	Thu, Dec 12, 1:05 PM

	Unknown Object (File)
	Mon, Dec 9, 12:30 AM

	Unknown Object (File)
	Sun, Dec 8, 10:45 AM

	Unknown Object (File)
	Tue, Dec 3, 8:53 PM

	Unknown Object (File)
	Sat, Nov 30, 6:07 AM

	Unknown Object (File)
	Tue, Nov 26, 7:26 AM

	Unknown Object (File)
	Tue, Nov 26, 7:06 AM

View All 95 Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13437: "Jump to Symbol" URIs from diff views are built without proper escaping
Commits: rPe1da1d86d680: Trim and URI encode symbol names before building URIs from them

Summary

Fixes T13437. This URI construction was just missing URI encoding.

Also, trim the symbol because my test case ended up catching "#define\n" as symbol text.

Test Plan

Configured a repository to have PHP symbols.
Touched a ".php" file with "#define" in it.
Diffed the change.
Command-clicked "#define" in the UI, in Safari/MacOS, to jump to the definition.
- Before: taken to a nonsense page where "#define" became an anchor.
- After: taken to symbol search for "#define".

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Oct 29 2019, 4:41 PM

Harbormaster completed remote builds in B23598: Diff 49769.Oct 29 2019, 4:43 PM

epriestley requested review of this revision.Oct 29 2019, 4:43 PM

This revision was not accepted when it landed; it landed in state Needs Review.Oct 29 2019, 4:48 PM

Closed by commit rPe1da1d86d680: Trim and URI encode symbol names before building URIs from them (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPe1da1d86d680: Trim and URI encode symbol names before building URIs from them.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

webroot/

rsrc/

js/

application/

repository/

repository-crossreference.js

11 lines

Diff 49770

resources/celerity/map.php

Loading...

webroot/rsrc/js/application/repository/repository-crossreference.js

Loading...