Page MenuHomePhabricator
Differential D20854

Use "git log ... --stdin" instead of "git log ... --not ..." to avoid oversized command lines
ClosedPublic
Actions

Authored by epriestley on Oct 2 2019, 8:28 PM.
Tags
None
Referenced Files
F14868260: D20854.id49713.diff
Sat, Feb 8, 1:58 AM
Unknown Object (File)
Thu, Feb 6, 2:28 PM
Unknown Object (File)
Sat, Jan 25, 5:56 AM
Unknown Object (File)
Sat, Jan 25, 5:56 AM
Unknown Object (File)
Sat, Jan 25, 5:56 AM
Unknown Object (File)
Sat, Jan 25, 5:56 AM
Unknown Object (File)
Thu, Jan 23, 2:07 AM
Unknown Object (File)
Wed, Jan 22, 6:32 AM
View All Files
Subscribers
None

Details

Reviewers
None
Commits
rP9d644f1bfea1: (stable) Use "git log ... --stdin" instead of "git log ... --not ..." to avoid…
rP7badec23a7d0: Use "git log ... --stdin" instead of "git log ... --not ..." to avoid oversized…
Summary

Depends on D20853. See PHI1474. If the list of "--not" refs is sufficiently long, we may exceed the maximum size of a command.

Use "--stdin" instead, and swap "--not" for the slightly less readable but functionally equivalent "^hash", which has the advantage of actually working with "--stdin".

Test Plan

Ran bin/repository refs ... with nothing to be done, and with something to be done.

Diff Detail

Repository
rP Phabricator
Branch
ref2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23541
Build 32353: Run Core Tests
Build 32352: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
repository/
engine/
25 lines

Diff 49713

View Options

src/applications/repository/engine/PhabricatorRepositoryRefEngine.php

Loading...
Phabricator · Built by Phacility