Page MenuHomePhabricator

Add a "Remove flag" action to Herald
ClosedPublic

Authored by epriestley on Sep 9 2019, 8:02 PM.

Details

Summary

Fixes T13409. This is a companion to the existing "Mark with flag" rule.

Test Plan

Used a "remove flag" rule on an object with no flag (not removed), the right type of flag (removed), and a different type of flag (not removed).

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Sep 9 2019, 8:02 PM
epriestley requested review of this revision.Sep 9 2019, 8:03 PM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 9 2019, 8:16 PM
This revision was automatically updated to reflect the committed changes.