Page MenuHomePhabricator
Differential D20796

Add a "Remove flag" action to Herald
ClosedPublic
Actions

Authored by epriestley on Sep 9 2019, 8:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jun 5, 4:40 PM
Unknown Object (File)
Sat, May 31, 4:47 AM
Unknown Object (File)
Thu, May 29, 8:00 AM
Unknown Object (File)
Mon, May 26, 3:05 PM
Unknown Object (File)
Mon, May 26, 9:57 AM
Unknown Object (File)
Sun, May 25, 5:24 PM
Unknown Object (File)
May 7 2025, 4:54 PM
Unknown Object (File)
Apr 21 2025, 10:58 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13409: Support a "Remove Flag" action in Herald
Commits
rP454771446306: Add a "Remove flag" action to Herald
Summary

Fixes T13409. This is a companion to the existing "Mark with flag" rule.

Test Plan

Used a "remove flag" rule on an object with no flag (not removed), the right type of flag (removed), and a different type of flag (not removed).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Sep 9 2019, 8:02 PM
Harbormaster completed remote builds in B23412: Diff 49587.Sep 9 2019, 8:03 PM
epriestley requested review of this revision.Sep 9 2019, 8:03 PM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 9 2019, 8:16 PM
Closed by commit rP454771446306: Add a "Remove flag" action to Herald (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP454771446306: Add a "Remove flag" action to Herald.

Revision Contents
Changeset List

Diff 49589

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/flag/herald/PhabricatorFlagAddFlagHeraldAction.php

Loading...
View Options

src/applications/flag/herald/PhabricatorFlagHeraldAction.php

Loading...
View Options

src/applications/flag/herald/PhabricatorFlagRemoveFlagHeraldAction.php

Loading...
Phabricator · Built by Phacility