Page MenuHomePhabricator

Add a "Remove flag" action to Herald
ClosedPublic

Authored by epriestley on Sep 9 2019, 8:02 PM.
Tags
None
Referenced Files
F18791699: D20796.diff
Thu, Oct 16, 4:59 PM
F18703054: D20796.id49589.diff
Sun, Sep 28, 2:50 AM
F18621071: D20796.id49589.diff
Sep 15 2025, 6:59 AM
F18591384: D20796.id.diff
Sep 12 2025, 9:04 AM
F18585953: D20796.diff
Sep 11 2025, 4:58 PM
F18570617: D20796.id49589.diff
Sep 10 2025, 3:59 AM
F18570616: D20796.id49587.diff
Sep 10 2025, 3:59 AM
F18567373: D20796.id.diff
Sep 9 2025, 3:43 PM
Subscribers
None

Details

Summary

Fixes T13409. This is a companion to the existing "Mark with flag" rule.

Test Plan

Used a "remove flag" rule on an object with no flag (not removed), the right type of flag (removed), and a different type of flag (not removed).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Sep 9 2019, 8:16 PM
This revision was automatically updated to reflect the committed changes.