Page MenuHomePhabricator

Add a "Remove flag" action to Herald
ClosedPublic

Authored by epriestley on Sep 9 2019, 8:02 PM.
Tags
None
Referenced Files
F19888221: D20796.diff
Mon, Mar 23, 11:20 PM
F19833147: D20796.id49589.diff
Wed, Mar 11, 12:57 AM
F19829658: D20796.id49589.diff
Tue, Mar 10, 7:22 AM
F19829645: D20796.diff
Tue, Mar 10, 7:17 AM
F19811969: D20796.diff
Mar 4 2026, 3:10 AM
F19720069: D20796.id49589.diff
Feb 12 2026, 8:03 PM
F19579642: D20796.diff
Feb 1 2026, 4:00 PM
F19546766: D20796.id.diff
Jan 25 2026, 6:00 PM
Subscribers
None

Details

Summary

Fixes T13409. This is a companion to the existing "Mark with flag" rule.

Test Plan

Used a "remove flag" rule on an object with no flag (not removed), the right type of flag (removed), and a different type of flag (not removed).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Sep 9 2019, 8:16 PM
This revision was automatically updated to reflect the committed changes.