Page MenuHomePhabricator

Index Herald fields, not just actions, when identifying objects related to a particular Herald rule
ClosedPublic

Authored by epriestley on Sep 9 2019, 7:44 PM.

Details

Summary

Fixes T13408. Currently, when a package (or other object) appears in a field (rather than an action), it is not indexed.

Instead: index fields too, not just actions.

Test Plan
  • Wrote a rule like "[ Affected packages include ] ...".
  • Updated the search index.
  • Saw rule appear on "Affected By Herald Rules" on the package detail page.

Diff Detail

Repository
rP Phabricator
Branch
herald1
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 23409
Build 32159: Run Core Tests
Build 32158: arc lint + arc unit

Event Timeline

Owners added a subscriber: Restricted Owners Package.Sep 9 2019, 7:44 PM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 9 2019, 7:50 PM
This revision was automatically updated to reflect the committed changes.