Page MenuHomePhabricator
Differential D20795

Index Herald fields, not just actions, when identifying objects related to a particular Herald rule
ClosedPublic
Actions

Authored by epriestley on Sep 9 2019, 7:44 PM.
Tags
None
Referenced Files
F15489500: D20795.id49586.diff
Fri, Apr 11, 9:24 AM
F15468236: D20795.id.diff
Thu, Apr 3, 9:59 PM
F15465110: D20795.diff
Wed, Apr 2, 2:41 PM
F15457057: D20795.diff
Sun, Mar 30, 2:03 PM
F15440613: D20795.diff
Wed, Mar 26, 1:49 PM
F15433446: D20795.id.diff
Mon, Mar 24, 11:14 PM
F15398936: D20795.diff
Mon, Mar 17, 1:56 AM
F15391773: D20795.id49586.diff
Sat, Mar 15, 11:32 AM
View All Files
Subscribers
Restricted Owners Package

Details

Reviewers
None
Maniphest Tasks
T13408: Examine conditions, not just actions, when indexing Herald rules for links to other objects
Commits
rPd965d9a669b5: Index Herald fields, not just actions, when identifying objects related to a…
Summary

Fixes T13408. Currently, when a package (or other object) appears in a field (rather than an action), it is not indexed.

Instead: index fields too, not just actions.

Test Plan
  • Wrote a rule like "[ Affected packages include ] ...".
  • Updated the search index.
  • Saw rule appear on "Affected By Herald Rules" on the package detail page.

Diff Detail

Repository
rP Phabricator
Branch
herald1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23409
Build 32159: Run Core Tests
Build 32158: arc lint + arc unit

Event Timeline

epriestley created this revision.Sep 9 2019, 7:44 PM
Owners added a subscriber: Restricted Owners Package.Sep 9 2019, 7:44 PM
Harbormaster completed remote builds in B23409: Diff 49584.Sep 9 2019, 7:45 PM
epriestley requested review of this revision.Sep 9 2019, 7:45 PM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 9 2019, 7:50 PM
Closed by commit rPd965d9a669b5: Index Herald fields, not just actions, when identifying objects related to a… (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rPd965d9a669b5: Index Herald fields, not just actions, when identifying objects related to a….

Revision Contents
Changeset List

PathSize
resources/
sql/
autopatches/
3 lines
src/
applications/
herald/
engineextension/
14 lines
field/
22 lines

Diff 49584

View Options

resources/sql/autopatches/20190909.herald.01.rebuild.php

Loading...
View Options

src/applications/herald/engineextension/HeraldRuleIndexEngineExtension.php

Loading...
View Options

src/applications/herald/field/HeraldField.php

Loading...
Phabricator · Built by Phacility