Differential D20793

Don't offer personal saved queries in global "Search Scope" settings dropdown
ClosedPublic
Actions

Authored by epriestley on Sep 9 2019, 7:16 PM.

Details

Reviewers: None
Maniphest Tasks: T13405: Support customization of the default global search scope
Commits: rPf87ec6a5dff9: (stable) Don't offer personal saved queries in global "Search Scope" settings…
rP278092974f2f: Don't offer personal saved queries in global "Search Scope" settings dropdown

Summary

Fixes T13405. We currently offer non-global custom saved queries here, but this doesn't make sense as a global default setting.

Test Plan

Saved a global search query, edited global search settings, no longer saw the non-global query as an option.

Diff Detail

Repository

rP Phabricator

Branch

global2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23402
Build 32150: Run Core Tests
Build 32149: arc lint + arc unit

Event Timeline

epriestley created this revision.Sep 9 2019, 7:16 PM

Harbormaster completed remote builds in B23402: Diff 49577.Sep 9 2019, 7:18 PM

epriestley requested review of this revision.Sep 9 2019, 7:18 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 9 2019, 7:21 PM

Closed by commit rP278092974f2f: Don't offer personal saved queries in global "Search Scope" settings dropdown (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP278092974f2f: Don't offer personal saved queries in global "Search Scope" settings dropdown.

epriestley added a commit: rPf87ec6a5dff9: (stable) Don't offer personal saved queries in global "Search Scope" settings….Sep 13 2019, 7:34 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

settings/

setting/

PhabricatorSearchScopeSetting.php

3 lines

view/

page/

menu/

PhabricatorMainMenuSearchView.php

17 lines

Diff 49577

View Options

src/applications/settings/setting/PhabricatorSearchScopeSetting.php