Page MenuHomePhabricator

Remove the "grant authority" mechanism from users
ClosedPublic

Authored by epriestley on Aug 30 2019, 4:15 PM.
Tags
None
Referenced Files
F14090333: D20754.diff
Sun, Nov 24, 5:16 PM
Unknown Object (File)
Sat, Nov 23, 1:26 PM
Unknown Object (File)
Mon, Nov 18, 9:19 PM
Unknown Object (File)
Sat, Nov 2, 7:38 PM
Unknown Object (File)
Mon, Oct 28, 3:08 PM
Unknown Object (File)
Oct 13 2024, 5:25 PM
Unknown Object (File)
Oct 9 2024, 12:39 PM
Unknown Object (File)
Oct 8 2024, 3:32 PM
Subscribers
None

Details

Summary

Ref T13393. See some previous discussion in T13366.

Caching is hard and all approaches here have downsides, but the request cache likely has fewer practical downsides for this kind of policy check than other approaches. In particular, the grant approach (at least, as previously used in Phortune) has a major downside that "Query" classes can no longer fully enforce policies.

Since Phortune no longer depends on grants and they've now been removed from instances, drop the mechanism completely.

Test Plan

Grepped for callsites, found none.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Aug 30 2019, 4:26 PM
This revision was automatically updated to reflect the committed changes.