Page MenuHomePhabricator

Remove the "grant authority" mechanism from users
ClosedPublic

Authored by epriestley on Aug 30 2019, 4:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 23, 7:06 PM
Unknown Object (File)
Sat, Mar 23, 3:40 AM
Unknown Object (File)
Sun, Mar 10, 7:50 AM
Unknown Object (File)
Feb 3 2024, 11:08 PM
Unknown Object (File)
Feb 3 2024, 9:01 AM
Unknown Object (File)
Jan 25 2024, 2:09 AM
Unknown Object (File)
Jan 16 2024, 9:49 AM
Unknown Object (File)
Jan 7 2024, 10:17 PM
Subscribers
None

Details

Summary

Ref T13393. See some previous discussion in T13366.

Caching is hard and all approaches here have downsides, but the request cache likely has fewer practical downsides for this kind of policy check than other approaches. In particular, the grant approach (at least, as previously used in Phortune) has a major downside that "Query" classes can no longer fully enforce policies.

Since Phortune no longer depends on grants and they've now been removed from instances, drop the mechanism completely.

Test Plan

Grepped for callsites, found none.

Diff Detail

Repository
rP Phabricator
Branch
authority1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23335
Build 32060: Run Core Tests
Build 32059: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Aug 30 2019, 4:26 PM
This revision was automatically updated to reflect the committed changes.