Differential D20700

In "Move task to..." workflow, separate visible and hidden columns in the dropdown
ClosedPublic
Actions

Authored by epriestley on Aug 7 2019, 4:18 PM.

Details

Reviewers: None
Maniphest Tasks: T13368: Correct several issues with "Move to Project..." on Workboards
Commits: rP0561043a1f57: In "Move task to..." workflow, separate visible and hidden columns in the…

Summary

Ref T13368. Currently, both visible and hidden columns are shown in the "Move tasks to..." dropdown on workflows from workboards.

When the dropdown contains hidden columns, move them to a separate section to make it clear that they're not likely targets.

Test Plan

Used "Move tasks to project..." targeting a board with no hidden columns. Saw a single ungrouped dropdown.
Used "Move tasks to project..." targeting a board with hidden columns. Saw a dropdown grouped into "Visible" and "Hidden" columns.

Diff Detail

Repository

rP Phabricator

Branch

column3

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23229
Build 31910: Run Core Tests
Build 31909: arc lint + arc unit

Event Timeline

epriestley created this revision.Aug 7 2019, 4:18 PM

Harbormaster completed remote builds in B23229: Diff 49364.Aug 7 2019, 4:20 PM

epriestley requested review of this revision.Aug 7 2019, 4:20 PM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 7 2019, 4:24 PM

Closed by commit rP0561043a1f57: In "Move task to..." workflow, separate visible and hidden columns in the… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP0561043a1f57: In "Move task to..." workflow, separate visible and hidden columns in the….

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

controller/

PhabricatorProjectColumnBulkMoveController.php

38 lines

Diff 49364

View Options

src/applications/project/controller/PhabricatorProjectColumnBulkMoveController.php

In "Move task to..." workflow, separate visible and hidden columns in the dropdownClosedPublicActions