Differential D20699

Don't show proxy (subproject/milestone) columns as options in "Move tasks..." workflows from workboards
ClosedPublic
Actions

Authored by epriestley on Aug 7 2019, 4:10 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Jan 17, 9:23 PM

	Unknown Object (File)
	Fri, Jan 17, 1:10 AM

	Unknown Object (File)
	Mon, Jan 13, 1:56 AM

	Unknown Object (File)
	Mon, Dec 30, 11:52 AM

	Unknown Object (File)
	Dec 14 2024, 9:03 PM

	Unknown Object (File)
	Dec 12 2024, 7:46 AM

	Unknown Object (File)
	Dec 11 2024, 12:37 PM

	Unknown Object (File)
	Dec 10 2024, 8:25 PM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13368: Correct several issues with "Move to Project..." on Workboards
Commits: rP6deac356599f: Don't show proxy (subproject/milestone) columns as options in "Move tasks..."…

Summary

Ref T13368. Proxy columns should not be selectable from this workflow. If you want to move tasks to milestone/subproject X, do "Move tasks to project..." and pick X as the project.

(This could be made to work some day.)

Test Plan

Went through a "Move tasks to project..." workflow targeting a project with subprojects. No longer saw subproject columns presented as dropdown options.

Diff Detail

Repository

Branch

column2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23228
Build 31908: Run Core Tests
Build 31907: arc lint + arc unit

Event Timeline

epriestley created this revision.Aug 7 2019, 4:10 PM

Harbormaster completed remote builds in B23228: Diff 49363.Aug 7 2019, 4:12 PM

epriestley requested review of this revision.Aug 7 2019, 4:12 PM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 7 2019, 4:23 PM

Closed by commit rP6deac356599f: Don't show proxy (subproject/milestone) columns as options in "Move tasks..."… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP6deac356599f: Don't show proxy (subproject/milestone) columns as options in "Move tasks..."….

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

controller/

PhabricatorProjectColumnBulkMoveController.php

9 lines

Diff 49363

src/applications/project/controller/PhabricatorProjectColumnBulkMoveController.php

Loading...