Page MenuHomePhabricator

Stop trying to CC merchants on invoices/receipts
ClosedPublic

Authored by epriestley on Aug 2 2019, 5:48 PM.

Details

Summary

Fixes T13341. Currently, cart emails (invoices/receipts) are sent to members of the associated merchant account. This was just a simple way to keep an eye on things when this was first written.

The system works fine, and recent changes (almost certainly D20525) stopped these emails from working (presumably because of the slightly weird merchant permissions model).

This could be sorted out in more detail, but it looks like the path forward is to introduce a side channel for email anyway (via T8389), and that's a better way to implement this behavior since it means the normal recipients won't see a bunch of random staff/merchant email addresses on their receipts.

Test Plan

Grepped for merchant in this editor.

Diff Detail

Repository
rP Phabricator
Branch
merchant1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23224
Build 31901: Run Core Tests
Build 31900: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Aug 2 2019, 5:50 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.