Page MenuHomePhabricator

Fix an issue where lines with more than one pattern match highlighted improperly in Diffusion
ClosedPublic

Authored by epriestley on Aug 2 2019, 4:42 PM.
Tags
None
Referenced Files
F18823587: D20695.diff
Thu, Oct 23, 12:35 PM
F18823033: D20695.diff
Thu, Oct 23, 9:54 AM
F18799318: D20695.id49358.diff
Fri, Oct 17, 1:11 PM
F18799307: D20695.id49358.diff
Fri, Oct 17, 1:09 PM
F18773459: D20695.diff
Thu, Oct 9, 10:08 AM
F18744795: D20695.id49357.diff
Oct 3 2025, 4:10 AM
F18738250: D20695.id.diff
Oct 1 2025, 2:53 PM
F18654244: D20695.diff
Sep 22 2025, 5:05 AM
Subscribers
None

Details

Summary

Ref T13339. If a search pattern matches more than once on a line, we currently render the line incorreclty, duplicating some of the text.

substr() is being called as though the third parameter was end_offset, but it's actually length. Correct the parameter.

Test Plan

Before:

Screen Shot 2019-08-02 at 9.40.04 AM.png (201×356 px, 12 KB)

After:

Screen Shot 2019-08-02 at 9.39.54 AM.png (191×349 px, 11 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Aug 2 2019, 4:43 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.