Page MenuHomePhabricator

Fix an issue where lines with more than one pattern match highlighted improperly in Diffusion
ClosedPublic

Authored by epriestley on Aug 2 2019, 4:42 PM.
Tags
None
Referenced Files
F18773459: D20695.diff
Thu, Oct 9, 10:08 AM
F18744795: D20695.id49357.diff
Fri, Oct 3, 4:10 AM
F18738250: D20695.id.diff
Wed, Oct 1, 2:53 PM
F18654244: D20695.diff
Mon, Sep 22, 5:05 AM
F18600076: D20695.diff
Sep 13 2025, 8:57 AM
F18567218: D20695.id.diff
Sep 9 2025, 3:36 PM
F18519278: D20695.diff
Sep 5 2025, 4:27 PM
F18510819: D20695.id.diff
Sep 5 2025, 5:15 AM
Subscribers
None

Details

Summary

Ref T13339. If a search pattern matches more than once on a line, we currently render the line incorreclty, duplicating some of the text.

substr() is being called as though the third parameter was end_offset, but it's actually length. Correct the parameter.

Test Plan

Before:

Screen Shot 2019-08-02 at 9.40.04 AM.png (201×356 px, 12 KB)

After:

Screen Shot 2019-08-02 at 9.39.54 AM.png (191×349 px, 11 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Aug 2 2019, 4:43 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.