Improve coverage of remarkup "<table>" rule and fix some bad method calls
ClosedPublic
Actions

Authored by epriestley on Jul 8 2019, 11:55 PM.

Details

Reviewers

Commits

rPHU8df85007f38e: (stable) Promote 2019 Week 31
rPHUb49ed9be94a8: (stable) Improve coverage of remarkup "<table>" rule and fix some bad method…
rPHUb416093386a2: Improve coverage of remarkup "<table>" rule and fix some bad method calls

Summary

See PHI1334. The existing coverage for "<table>" in remarkup is all testing valid inputs, and we have some incorrect method call names when the input isn't valid.

Add coverage, then make it pass.

Test Plan

Added tests and made them pass. Rendered some questionable <table>-like tags in comment previews.

Diff Detail

Repository

rPHU libphutil

Branch

remark1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23117
Build 31740: Run Core Tests
Build 31739: arc lint + arc unit

Event Timeline

epriestley created this revision.Jul 8 2019, 11:55 PM

Harbormaster completed remote builds in B23117: Diff 49249.Jul 8 2019, 11:55 PM

epriestley requested review of this revision.Jul 8 2019, 11:55 PM

I'm going to fast-track this to production since the fatal in PHI1334 is particularly unlucky (repository landing page) and I'm pretty confident the change doesn't make anything worse.

This revision was not accepted when it landed; it landed in state Needs Review.Jul 8 2019, 11:57 PM

Closed by commit rPHUb416093386a2: Improve coverage of remarkup "<table>" rule and fix some bad method calls (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPHUb416093386a2: Improve coverage of remarkup "<table>" rule and fix some bad method calls.

epriestley added a commit: rPHUb49ed9be94a8: (stable) Improve coverage of remarkup "<table>" rule and fix some bad method….

amckinley awarded a token.Jul 9 2019, 12:42 AM

epriestley added a commit: rPHU8df85007f38e: (stable) Promote 2019 Week 31.Jul 31 2019, 7:02 PM