Page MenuHomePhabricator

Improve coverage of remarkup "<table>" rule and fix some bad method calls
ClosedPublic

Authored by epriestley on Jul 8 2019, 11:55 PM.
Tags
None
Referenced Files
F15382408: D20644.diff
Fri, Mar 14, 12:12 PM
F15375743: D20644.diff
Wed, Mar 12, 11:56 PM
F15301475: D20644.id49249.diff
Wed, Mar 5, 5:52 PM
Unknown Object (File)
Tue, Feb 18, 8:12 AM
Unknown Object (File)
Feb 15 2025, 10:45 PM
Unknown Object (File)
Feb 10 2025, 4:02 AM
Unknown Object (File)
Feb 10 2025, 4:02 AM
Unknown Object (File)
Feb 10 2025, 4:02 AM
Subscribers
None
Tokens
"Baby Tequila" token, awarded by amckinley.

Details

Summary

See PHI1334. The existing coverage for "<table>" in remarkup is all testing valid inputs, and we have some incorrect method call names when the input isn't valid.

Add coverage, then make it pass.

Test Plan

Added tests and made them pass. Rendered some questionable <table>-like tags in comment previews.

Diff Detail

Repository
rPHU libphutil
Branch
remark1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23117
Build 31740: Run Core Tests
Build 31739: arc lint + arc unit

Event Timeline

I'm going to fast-track this to production since the fatal in PHI1334 is particularly unlucky (repository landing page) and I'm pretty confident the change doesn't make anything worse.