Page MenuHomePhabricator
Differential D20603

Remove "PhutilDaemonOverseer->findRunningDaemons()"
ClosedPublic
Actions

Authored by epriestley on Jun 20 2019, 9:25 PM.

Details

Reviewers
amckinley
Maniphest Tasks
T13321: "bin/phd" may try to kill processes it does not own if the daemon PID logfiles on disk are out of date
Commits
rPHUac8e57402236: Remove "PhutilDaemonOverseer->findRunningDaemons()"
Summary

Ref T13321. This was obsoleted by "PhutilProcessQuery" in D20600, and the only callsite was removed in D20601.

Test Plan

Grepped for findRunningDaemons().

Diff Detail

Repository
rPHU libphutil
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Jun 20 2019, 9:25 PM
epriestley requested review of this revision.Jun 20 2019, 9:25 PM
amckinley accepted this revision.Jun 20 2019, 10:34 PM
This revision is now accepted and ready to land.Jun 20 2019, 10:34 PM
Closed by commit rPHUac8e57402236: Remove "PhutilDaemonOverseer->findRunningDaemons()" (authored by epriestley). · Explain WhyJun 24 2019, 6:23 PM
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rPHUac8e57402236: Remove "PhutilDaemonOverseer->findRunningDaemons()".

Revision Contents
Changeset List

PathPackages
Msrc/daemon/PhutilDaemonOverseer.php (63 lines)

Diff 49169

View Options

src/daemon/PhutilDaemonOverseer.php

Loading...
Phabricator · Built by Phacility