Page MenuHomePhabricator

Skip loading transaction handles in an old migration
ClosedPublic

Authored by epriestley on Jun 5 2019, 6:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 24, 11:06 AM
Unknown Object (File)
Sat, Mar 23, 12:40 PM
Unknown Object (File)
Feb 26 2024, 8:16 PM
Unknown Object (File)
Feb 12 2024, 12:42 AM
Unknown Object (File)
Dec 26 2023, 7:55 AM
Unknown Object (File)
Dec 24 2023, 9:12 AM
Unknown Object (File)
Dec 22 2023, 5:42 PM
Unknown Object (File)
Dec 22 2023, 2:22 AM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13305. See that task for discussion.

This old migration may indirectly cause search index worker tasks to queue by loading handles. They'll fail since we later added dateCreated to the worker task table.

Use needHandles(false) (since we don't use them) to disable loading handles and avoid the problem.

Test Plan
  • Ran bin/storage upgrade -f on an older instance (late 2016) and hit this issue.
  • Applied the patch, got a clean migration to modernity.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable