Page MenuHomePhabricator

Fix a looping workflow when trying to submit a partially-effectless transaction group
ClosedPublic

Authored by epriestley on May 23 2019, 6:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jun 29, 3:11 AM
Unknown Object (File)
Sat, Jun 25, 8:49 PM
Unknown Object (File)
Fri, Jun 24, 10:46 AM
Unknown Object (File)
Tue, Jun 21, 2:36 PM
Unknown Object (File)
Thu, Jun 16, 9:12 AM
Unknown Object (File)
Tue, Jun 14, 4:57 AM
Unknown Object (File)
Sat, Jun 11, 1:50 AM
Unknown Object (File)
Fri, Jun 10, 11:55 AM
Subscribers
None

Details

Summary

Ref T13289. If you do this:

  • Subscribe to a task (so we don't generate a subscribe side-effect later).
  • Prepare a transaction group: sign with MFA, change projects (don't make any changes), add a comment.
  • Submit the transaction group.

...you'll get prompted "Some actions don't have any effect (the non-change to projects), apply remaining effects?".

If you confirm, you get MFA'd, but the MFA flow loses the "continue" confirmation, so you get trapped in a workflow loop of confirming and MFA'ing.

Instead, retain the "continue" bit through the MFA.

Also, don't show "You can't sign an empty transaction group" if there's a comment.

See also T13295, since the amount of magic here can probably be reduced. There's likely little reason for "continue" or "hisec" to be magic nowadays.

Test Plan
  • Went through the workflow above.
  • Before: looping workflow.
  • After: "Continue" carries through the MFA gate.

Diff Detail

Repository
rP Phabricator
Branch
mfa1x
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22901
Build 31416: Run Core Tests
Build 31415: arc lint + arc unit