Page MenuHomePhabricator

Fix a looping workflow when trying to submit a partially-effectless transaction group
ClosedPublic

Authored by epriestley on May 23 2019, 6:45 PM.
Tags
None
Referenced Files
F18779357: D20552.id49027.diff
Sat, Oct 11, 1:36 PM
F18778875: D20552.id.diff
Sat, Oct 11, 11:11 AM
F18745280: D20552.id49037.diff
Fri, Oct 3, 6:02 AM
F18740563: D20552.diff
Thu, Oct 2, 4:00 AM
F18682024: D20552.id49027.diff
Fri, Sep 26, 5:09 AM
F18680874: D20552.id49027.diff
Fri, Sep 26, 3:16 AM
F18655206: D20552.diff
Mon, Sep 22, 7:21 PM
F18654805: D20552.diff
Mon, Sep 22, 5:42 PM
Subscribers
None

Details

Summary

Ref T13289. If you do this:

  • Subscribe to a task (so we don't generate a subscribe side-effect later).
  • Prepare a transaction group: sign with MFA, change projects (don't make any changes), add a comment.
  • Submit the transaction group.

...you'll get prompted "Some actions don't have any effect (the non-change to projects), apply remaining effects?".

If you confirm, you get MFA'd, but the MFA flow loses the "continue" confirmation, so you get trapped in a workflow loop of confirming and MFA'ing.

Instead, retain the "continue" bit through the MFA.

Also, don't show "You can't sign an empty transaction group" if there's a comment.

See also T13295, since the amount of magic here can probably be reduced. There's likely little reason for "continue" or "hisec" to be magic nowadays.

Test Plan
  • Went through the workflow above.
  • Before: looping workflow.
  • After: "Continue" carries through the MFA gate.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable