Differential D20537

Support "none()" in Differential to find revisions with no (un-resigned) reviewers
ClosedPublic
Actions

Authored by epriestley on May 21 2019, 2:26 PM.

Tags

None

Referenced Files

	F14760320: D20537.id48968.diff
	Wed, Jan 22, 5:40 PM

	Unknown Object (File)
	Tue, Jan 21, 9:31 AM

	Unknown Object (File)
	Dec 17 2024, 10:31 AM

	Unknown Object (File)
	Dec 12 2024, 6:28 AM

	Unknown Object (File)
	Dec 3 2024, 7:31 PM

	Unknown Object (File)
	Oct 22 2024, 12:49 PM

	Unknown Object (File)
	Oct 16 2024, 12:01 PM

	Unknown Object (File)
	Oct 9 2024, 12:21 PM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T13289: Plans: 2019 Week 21-23 Bonus Content

Commits

rP7c1f6519e0b2: Support "none()" in Differential to find revisions with no (un-resigned)…

Summary

Ref T13289. In Maniphest, you can currently search for "Owner: none()" to find tasks with no owner, but there's no way to search for "Reviewers: none()" in Differential right now.

Add support for this, since it's consistent and reasonable and doesn't seem too weird or niche.

Test Plan

Searched for "Reviewers: none()", found revisions with no reviewers. Searched for "Reviewers: alice, none()", "Reviewers: alice", and "Reviewers: <no constraint>" and got sensible results.

Diff Detail

Repository

Branch

noreviewers1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 22844
Build 31342: Run Core Tests
Build 31341: arc lint + arc unit

Event Timeline

epriestley created this revision.May 21 2019, 2:26 PM

Harbormaster completed remote builds in B22844: Diff 48968.May 21 2019, 2:27 PM

epriestley requested review of this revision.May 21 2019, 2:27 PM

amckinley edited the summary of this revision. (Show Details)May 21 2019, 5:07 PM

amckinley accepted this revision.May 21 2019, 6:44 PM

This revision is now accepted and ready to land.May 21 2019, 6:44 PM

Closed by commit rP7c1f6519e0b2: Support "none()" in Differential to find revisions with no (un-resigned)… (authored by epriestley). · Explain WhyMay 21 2019, 7:57 PM

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP7c1f6519e0b2: Support "none()" in Differential to find revisions with no (un-resigned)….

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

applications/

differential/

query/

DifferentialRevisionQuery.php

60 lines

DifferentialRevisionSearchEngine.php

2 lines

typeahead/

DifferentialNoReviewersDatasource.php

78 lines

DifferentialReviewerFunctionDatasource.php

26 lines

view/

DifferentialRevisionListView.php

10 lines

Diff 48968

src/__phutil_library_map__.php

Loading...

src/applications/differential/query/DifferentialRevisionQuery.php

Loading...

src/applications/differential/query/DifferentialRevisionSearchEngine.php

Loading...

src/applications/differential/typeahead/DifferentialNoReviewersDatasource.php

Loading...

src/applications/differential/typeahead/DifferentialReviewerFunctionDatasource.php

Loading...

src/applications/differential/view/DifferentialRevisionListView.php

Loading...