Page MenuHomePhabricator

Add a "Reports" menu item to Projects
ClosedPublic

Authored by epriestley on May 3 2019, 6:54 PM.
Tags
None
Referenced Files
F15447154: D20495.id48996.diff
Thu, Mar 27, 10:10 PM
F15442193: D20495.id.diff
Wed, Mar 26, 10:04 PM
F15434625: D20495.diff
Tue, Mar 25, 4:42 AM
F15434029: D20495.diff
Tue, Mar 25, 1:35 AM
F15416191: D20495.diff
Thu, Mar 20, 9:48 AM
F15413746: D20495.diff
Wed, Mar 19, 9:03 PM
F15341245: D20495.diff
Sun, Mar 9, 7:15 PM
F15310293: D20495.id48996.diff
Thu, Mar 6, 8:38 AM
Subscribers
None

Details

Summary

Ref T13279. Since the use cases that have made it upstream are all for relatively complex charts (e.g., requiring aggregation and composition of multiple data series in nontrivial ways) I'm currently looking at an overall approach like this:

  • At least for now, Charts provides a low-level internal-only API for composing charts from raw datasets.
  • This is exposed to users through pre-built SearchEngine-like interfaces that provide a small number of more manageable controls (show chart from date X to date Y, show projects A, B, C), but not the full set of composition features (compose(scale(2), cos()) and such).
  • Eventually, we may put more UI on the raw chart composition stuff and let you build your own fully custom charts by gluing together datasets and functions.
  • Or we may add this stuff in piecemeal to the higher-level UI as tools like "add goal line" or "add trend line" or whatever.

This will let the low-level API mature/evolve a bit before users get hold of it directly, if they ever do. Most requests today are likely satisfiable with a small number of chart engines plus raw API data access, so maybe UI access to flexible charting is far away.

Step toward this by adding a "Reports" section to projects. For now, this just renders a basic burnup for the current project. Followups will add an "Engine" layer above this and make the chart it produces more useful.

Test Plan

Screen Shot 2019-05-03 at 11.53.18 AM.png (1×2 px, 290 KB)

Diff Detail

Repository
rP Phabricator
Branch
chart19
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22760
Build 31208: Run Core Tests
Build 31207: arc lint + arc unit