Differential D20471

Set a URI on Auth Messages, so the "Change Details" dialog from the transaction record has a cancel button
ClosedPublic
Actions

Authored by epriestley on Apr 25 2019, 3:11 PM.

Details

Reviewers

Summary

If you edit an auth message in Auth > Customize Messages, then click "Show Details" in the transaction record, the resulting dialog uses the object's handle's URI to generate a "cancel" button.

Since these handles currently have no URI, the dialog currently has no cancel/done button to close it.

Test Plan

Edited an auth message, clicked "Show Details", was now able to click "Done" to close the dialog.

Diff Detail

Repository

rP Phabricator

Branch

cancel1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 22715
Build 31134: Run Core Tests
Build 31133: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 25 2019, 3:11 PM

Harbormaster completed remote builds in B22715: Diff 48840.Apr 25 2019, 3:13 PM

epriestley requested review of this revision.Apr 25 2019, 3:13 PM

amckinley accepted this revision.Apr 29 2019, 7:52 PM

This revision is now accepted and ready to land.Apr 29 2019, 7:52 PM

Closed by commit rP648d5ce19076: Set a URI on Auth Messages, so the "Change Details" dialog from the transaction… (authored by epriestley). · Explain WhyApr 30 2019, 1:59 PM

This revision was automatically updated to reflect the committed changes.

epriestley added an edge: rP648d5ce19076: Set a URI on Auth Messages, so the "Change Details" dialog from the transaction….

Revision Contents
Changeset List

Path

Size

src/

applications/

auth/

phid/

PhabricatorAuthMessagePHIDType.php

6 lines

Diff 48840

View Options

src/applications/auth/phid/PhabricatorAuthMessagePHIDType.php

Set a URI on Auth Messages, so the "Change Details" dialog from the transaction record has a cancel buttonClosedPublicActions