Page MenuHomePhabricator

Change "Revision Close" story to use commit identities only with no fallback to commit data
ClosedPublic

Authored by epriestley on Apr 22 2019, 7:46 PM.
Tags
None
Referenced Files
F12808648: D20460.id48814.diff
Wed, Mar 27, 8:46 PM
Unknown Object (File)
Tue, Mar 19, 3:18 PM
Unknown Object (File)
Jan 23 2024, 10:49 AM
Unknown Object (File)
Dec 26 2023, 9:49 PM
Unknown Object (File)
Dec 22 2023, 6:47 PM
Unknown Object (File)
Dec 15 2023, 5:33 AM
Unknown Object (File)
Dec 13 2023, 3:24 AM
Unknown Object (File)
Nov 30 2023, 5:54 AM
Subscribers
None

Details

Summary

See PHI1213. If we don't have identities for "revision X closed by commit Y" stories, just do the plain non-attribution rendering rather than trying to fall back. Falling back won't work since we don't load the data, which should be OK now since identities seem like they're in generally good shape.

(We could probably just throw out the fallback behavior instead, but we can always clean things up later.)

Test Plan

Forced no commit identity on a revision, loaded it, saw reasonable story rendering.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Specifically, the problem is that getAuthorDisplayPHID() does if (!$identity) { $this->getData()->... } which throws, since we didn't needCommitData(). But I want to move toward a future where we really don't need the commit data, and this seems like a good opportunity to step in that direction.

This revision is now accepted and ready to land.Apr 23 2019, 5:47 PM