Differential D20460
Change "Revision Close" story to use commit identities only with no fallback to commit data Authored by epriestley on Apr 22 2019, 7:46 PM. Tags None Referenced Files
Subscribers None
Details See PHI1213. If we don't have identities for "revision X closed by commit Y" stories, just do the plain non-attribution rendering rather than trying to fall back. Falling back won't work since we don't load the data, which should be OK now since identities seem like they're in generally good shape. (We could probably just throw out the fallback behavior instead, but we can always clean things up later.) Forced no commit identity on a revision, loaded it, saw reasonable story rendering.
Diff Detail
Event TimelineComment Actions Specifically, the problem is that getAuthorDisplayPHID() does if (!$identity) { $this->getData()->... } which throws, since we didn't needCommitData(). But I want to move toward a future where we really don't need the commit data, and this seems like a good opportunity to step in that direction. |