Page MenuHomePhabricator

Fix an issue where internal paging of notifications could fail if some notifications are not visible
ClosedPublic

Authored by epriestley on Apr 22 2019, 2:27 PM.
Tags
None
Referenced Files
F18902324: D20455.diff
Nov 8 2025, 12:40 AM
F18900513: D20455.id48809.diff
Nov 7 2025, 9:07 PM
F18898104: D20455.id.diff
Nov 7 2025, 6:15 PM
F18895787: D20455.diff
Nov 7 2025, 3:25 PM
F18863265: D20455.diff
Nov 2 2025, 10:35 PM
F18804005: D20455.id.diff
Oct 18 2025, 5:24 AM
F18786717: D20455.diff
Oct 14 2025, 8:06 PM
F18703835: D20455.id48809.diff
Sep 28 2025, 5:12 AM
Subscribers

Details

Summary

Ref T13266. See https://discourse.phabricator-community.org/t/notification-page-throws-unrecoverable-fatal-error/2651/.

The "notifications" query currently uses offset paging for no apparent reason (just a legacy issue?), so some of the paging code is only reachable internally.

  • Stop it from using offset paging, since modern cursor paging is fine here (and Feed has used cursor paging for a long time).
  • Fix the non-offset paging to work like Feed.

Also:

  • Remove a couple of stub methods with no callsites after cursor refactoring.
Test Plan
  • Set things up so I had more than 100 notifications and some in the first 100 were policy filtered, to reproduce the issue (I just made FeedStory return NO_ONE as a visibility policy).
  • Applied the patch, notifications now page cleanly.
  • Verified that "Next Page" took me to the right place in the result list.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable