Page MenuHomePhabricator

Copy the "line-chart" behavior to "line-chart-legacy" to keep "Maniphest > Reports" working
ClosedPublic

Authored by epriestley on Apr 18 2019, 1:41 PM.
Tags
None
Referenced Files
F13050755: D20449.id48807.diff
Fri, Apr 19, 3:10 AM
F13050754: D20449.id48790.diff
Fri, Apr 19, 3:10 AM
F13050753: D20449.id.diff
Fri, Apr 19, 3:10 AM
Unknown Object (File)
Mon, Apr 15, 10:55 PM
Unknown Object (File)
Thu, Apr 11, 7:15 AM
Unknown Object (File)
Thu, Apr 11, 4:18 AM
Unknown Object (File)
Sat, Apr 6, 9:03 AM
Unknown Object (File)
Sat, Mar 23, 10:34 AM
Subscribers
None

Details

Summary

Ref T13279. Charting changes alter how the "line-chart" behavior works, but the "Burnup Chart" still relies on the old behavior.

Although I'm intending to remove "Maniphest > Reports" once Facts is a minimally sufficient replacement, copy this behavior to keep it working until we're ready to pull the trigger.

Also fix a leftover typo from D20435.

Test Plan

Viewed a legacy Maniphest burnup rate report.

Diff Detail

Repository
rP Phabricator
Branch
chart1x
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningwebroot/rsrc/js/application/maniphest/behavior-line-chart-legacy.js:1JAVELIN5`javelinsymbols` Not In Path
Unit
Tests Passed
Build Status
Buildable 22662
Build 31057: Run Core Tests
Build 31056: arc lint + arc unit

Event Timeline

amckinley added inline comments.
webroot/rsrc/js/application/maniphest/behavior-line-chart-legacy.js
9

Didn't review; assuming it's a faithful copy from the original.

This revision is now accepted and ready to land.Apr 19 2019, 12:26 AM
This revision was landed with ongoing or failed builds.Apr 19 2019, 2:05 PM
This revision was automatically updated to reflect the committed changes.